Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update csi-driver-smb unit test configuration #61509

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

rhrmo
Copy link
Contributor

@rhrmo rhrmo commented Feb 11, 2025

Update unit tests configuration to run same as on upstream

@openshift-ci openshift-ci bot requested review from jsafrane and tsmetana February 11, 2025 12:00
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@rhrmo: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-csi-driver-smb-release-4.20-unit openshift/csi-driver-smb presubmit Ci-operator config changed
pull-ci-openshift-csi-driver-smb-release-4.17-unit openshift/csi-driver-smb presubmit Ci-operator config changed
pull-ci-openshift-csi-driver-smb-release-4.18-unit openshift/csi-driver-smb presubmit Ci-operator config changed
pull-ci-openshift-csi-driver-smb-release-4.19-unit openshift/csi-driver-smb presubmit Ci-operator config changed
pull-ci-openshift-csi-driver-smb-master-unit openshift/csi-driver-smb presubmit Ci-operator config changed
pull-ci-openshift-csi-driver-smb-release-4.16-unit openshift/csi-driver-smb presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rhrmo
Copy link
Contributor Author

rhrmo commented Feb 11, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@rhrmo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rhrmo
Copy link
Contributor Author

rhrmo commented Feb 11, 2025

/pj-rehearse ci/rehearse/openshift/csi-driver-smb/release-4.17/unit

@openshift-ci-robot
Copy link
Contributor

@rhrmo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@rhrmo: job(s): ci/rehearse/openshift/csi-driver-smb/release-4.17/unit either don't exist or were not found to be affected, and cannot be rehearsed

@RomanBednar
Copy link
Contributor

/pj-rehearse pull-ci-openshift-csi-driver-smb-release-4.17-unit

@openshift-ci-robot
Copy link
Contributor

@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RomanBednar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhrmo, RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
@rhrmo
Copy link
Contributor Author

rhrmo commented Feb 11, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@rhrmo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 11, 2025
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

@rhrmo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2cc93e0 into openshift:master Feb 11, 2025
19 checks passed
anpingli pushed a commit to anpingli/release that referenced this pull request Feb 19, 2025
phani2898 pushed a commit to phani2898/release that referenced this pull request Feb 26, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants