fix(tooltip): [tooltip] fix dark theme views #3241
Conversation
WalkthroughThe pull request updates UI styling in both tooltip components and table themes. In the tooltip components, it changes the hover background color for elements with the class Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
examples/sites/demos/pc/app/tooltip/control-composition-api.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. examples/sites/demos/pc/app/tooltip/control.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis PR addresses issues with the dark theme views for tooltip and transfer components. It modifies the background color for hover states in tooltip demos and updates table styles to improve dark theme compatibility. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| @@ -57,7 +58,7 @@ | |||
| text-align: center; | |||
| vertical-align: middle; | |||
| color: var(--tv-Table-nodata-text-color); | |||
There was a problem hiding this comment.
The change from fill to border-radius and path-specific fill logic for SVG icons may affect the rendering of icons. Ensure that the new styles are compatible with all supported browsers and do not introduce visual regressions.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
examples/sites/demos/pc/app/tooltip/control-composition-api.vue (1)
82-84: Update tooltip hover background color for dark theme compatibility.
The hover background color for elements with the.ellipsisclass is changed to#5291ffto improve visibility in dark themes. Please confirm that this color meets the design contrast and accessibility guidelines.examples/sites/demos/pc/app/tooltip/control.vue (1)
91-93: Unify tooltip hover styling across components.
The hover background color update to#5291fffor the.ellipsisclass ensures consistency with the composition API version and enhances dark theme presentation. Please verify that the new color complies with the overall design system.packages/theme/src/table/index.less (2)
32-32: Introduce bottom border for table rows.
Addingborder-bottom: 1px solid var(--tv-Table-border-color);to table row styles under the.simpleclass improves row separation and visual clarity. This change supports both light and dark themes by leveraging design tokens.
119-134: Refine SVG icon styling in table cells.
The updated block applies a properborder-radiusviavar(--tv-Table-check-icon-border-radius)and adjusts the fill colors for the SVG paths to use updated design tokens. Please verify that these changes render correctly in various themes, including dark mode, and that the visual feedback is as intended.packages/theme/src/table/vars.less (1)
31-41: Update and extend table styling variables.
The update of--tv-Table-border-colorto usevar(--tv-color-border-divider)along with the introduction of new variables (--tv-Table-half-check-icon-colorand--tv-Table-check-icon-border-radius) enhances the consistency and flexibility of table component theming. Ensure that these tokens are correctly consumed by the related styles in the theme.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
examples/sites/demos/pc/app/tooltip/control-composition-api.vue(1 hunks)examples/sites/demos/pc/app/tooltip/control.vue(1 hunks)packages/theme/src/table/index.less(3 hunks)packages/theme/src/table/vars.less(1 hunks)
lcy0620
changed the title
|
@all-contributors please add @lcy0620 for code. |
|
I've put up a pull request to add @lcy0620! 🎉 |
PR
PR Checklist
fix(tooltip): [tooltip,transfer] fix dark theme views
解决transfer暗黑主题检视意见
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit