Skip to content

fix(tooltip): [tooltip] fix dark theme views #3241

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

fix(tooltip): [tooltip] fix dark theme views #3241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/sites/demos/pc/app/tooltip/control-composition-api.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,6 @@ const disabled = ref(false)
cursor: pointer;
}
.ellipsis:hover {
background-color: #c0c0c0;
background-color: #5291ff;
}
</style>
2 changes: 1 addition & 1 deletion examples/sites/demos/pc/app/tooltip/control.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,6 @@ export default {
cursor: pointer;
}
.ellipsis:hover {
background-color: #c0c0c0;
background-color: #5291ff;
}
</style>
21 changes: 17 additions & 4 deletions packages/theme/src/table/index.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
display: table-row;
vertical-align: inherit;
border-color: inherit;
border-bottom: 1px solid var(--tv-Table-border-color);
}

tbody {
Expand Down Expand Up @@ -57,7 +58,7 @@
text-align: center;
vertical-align: middle;
color: var(--tv-Table-nodata-text-color);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from fill to border-radius and path-specific fill logic for SVG icons may affect the rendering of icons. Ensure that the new styles are compatible with all supported browsers and do not introduce visual regressions.

background-color: transparent;
background-color: transparent;
}
}
}
Expand Down Expand Up @@ -115,10 +116,22 @@
.@{table-cell-prefix-cls} {
.@{svg-prefix-cls} {
font-size: var(--tv-Table-icon-font-size);
fill: var(--tv-Table-border-color);
border-radius: var(--tv-Table-check-icon-border-radius);
& path:last-child{
fill: var(--tv-Table-border-color);
}

&.is-check {
fill: var(--tv-Table-check-icon-color);
& path:first-child {
fill: transparent;
}
&.is-check {
& path:last-child{
fill: var(--tv-Table-half-check-icon-color);
}

& path:first-child {
fill: var(--tv-Table-check-icon-color);
}
}
}
}
Expand Down
7 changes: 6 additions & 1 deletion packages/theme/src/table/vars.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,16 @@
// 表格单元格字体大小
--tv-Table-td-font-size: var(--tv-font-size-default, 14px);
// 表格边框颜色
--tv-Table-border-color: var(--tv-color-border, #c2c2c2);
--tv-Table-border-color: var(--tv-color-border-divider);
// 表头背景颜色
--tv-Table-thead-bg-color: var(--tv-color-bg-header, #f5f5f5);
// 表格图标字体大小
--tv-Table-icon-font-size: var(--tv-font-size-lg, 16px);
// 表格复选框选中图标颜色
--tv-Table-check-icon-color: var(--tv-color-icon-control-active, #1476ff);
// 表格复选框半选色
--tv-Table-half-check-icon-color: var(--tv-color-text-inverse);
// 表格复选框边框圆角
--tv-Table-check-icon-border-radius: var(--tv-border-radius-sm);

}
Loading