Test refactor

[PWAlessi]

Refactor unit tests

[codecov]

Codecov Report

Merging #97 (826aa0c) into main (ea76149) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   48.93%   48.93%           
=======================================
  Files           5        5           
  Lines        1216     1216           
=======================================
  Hits          595      595           
  Misses        602      602           
  Partials       19       19           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[glimchb]

@PWAlessi we have 4 common functions in tests:

• dialer()
• spdkMockServer()
• startSpdkMockupServer()
• startGrpcMockupServer()

is there are standard way to handle it in golang ? create a new file for common UT things... ?

[PWAlessi]

Yes, I will refactor. On Jan 12, 2023, at 3:49 PM, Boris Glimcher ***@***.***> wrote: Merged #97 into main. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[glimchb]

Yes, I will refactor

cool, thanks!

and we should probably repeat that for https://github.com/opiproject/opi-marvell-bridge and https://github.com/opiproject/opi-nvidia-bridge as well

I don't like how much dup we have between repos... but not sure there is anything we can do...