Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test refactor #97

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Test refactor #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a612c2e
Refactor front-end tests
pwalessi-dell Jan 12, 2023
826aa0c
Refactor back-end and middle-end tests
pwalessi-dell Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
170 changes: 37 additions & 133 deletions server/backend_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,14 @@ package main

import (
"bytes"
"context"
"fmt"
"log"
"net"
"os"
"reflect"
"testing"

"google.golang.org/grpc"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/credentials/insecure"
"google.golang.org/grpc/status"
"google.golang.org/protobuf/proto"
"google.golang.org/protobuf/types/known/emptypb"
Expand All @@ -25,6 +22,15 @@ import (
)

func TestBackEnd_CreateNVMfRemoteController(t *testing.T) {
controller := &pb.NVMfRemoteController{
Id: &pc.ObjectKey{Value: "OpiNvme8"},
Trtype: pb.NvmeTransportType_NVME_TRANSPORT_TCP,
Adrfam: pb.NvmeAddressFamily_NVMF_ADRFAM_IPV4,
Traddr: "127.0.0.1",
Trsvcid: 4444,
Subnqn: "nqn.2016-06.io.spdk:cnode1",
Hostnqn: "nqn.2014-08.org.nvmexpress:uuid:feb98abe-d51f-40c8-b348-2753f3571d3c",
}
tests := []struct {
name string
in *pb.NVMfRemoteController
Expand All @@ -36,15 +42,7 @@ func TestBackEnd_CreateNVMfRemoteController(t *testing.T) {
}{
{
"valid request with invalid marshal SPDK response",
&pb.NVMfRemoteController{
Id: &pc.ObjectKey{Value: "OpiNvme8"},
Trtype: pb.NvmeTransportType_NVME_TRANSPORT_TCP,
Adrfam: pb.NvmeAddressFamily_NVMF_ADRFAM_IPV4,
Traddr: "127.0.0.1",
Trsvcid: 4444,
Subnqn: "nqn.2016-06.io.spdk:cnode1",
Hostnqn: "nqn.2014-08.org.nvmexpress:uuid:feb98abe-d51f-40c8-b348-2753f3571d3c",
},
controller,
nil,
[]string{`{"id":%d,"error":{"code":0,"message":""},"result":false}`},
codes.Unknown,
Expand All @@ -53,15 +51,7 @@ func TestBackEnd_CreateNVMfRemoteController(t *testing.T) {
},
{
"valid request with empty SPDK response",
&pb.NVMfRemoteController{
Id: &pc.ObjectKey{Value: "OpiNvme8"},
Trtype: pb.NvmeTransportType_NVME_TRANSPORT_TCP,
Adrfam: pb.NvmeAddressFamily_NVMF_ADRFAM_IPV4,
Traddr: "127.0.0.1",
Trsvcid: 4444,
Subnqn: "nqn.2016-06.io.spdk:cnode1",
Hostnqn: "nqn.2014-08.org.nvmexpress:uuid:feb98abe-d51f-40c8-b348-2753f3571d3c",
},
controller,
nil,
[]string{""},
codes.Unknown,
Expand All @@ -70,15 +60,7 @@ func TestBackEnd_CreateNVMfRemoteController(t *testing.T) {
},
{
"valid request with ID mismatch SPDK response",
&pb.NVMfRemoteController{
Id: &pc.ObjectKey{Value: "OpiNvme8"},
Trtype: pb.NvmeTransportType_NVME_TRANSPORT_TCP,
Adrfam: pb.NvmeAddressFamily_NVMF_ADRFAM_IPV4,
Traddr: "127.0.0.1",
Trsvcid: 4444,
Subnqn: "nqn.2016-06.io.spdk:cnode1",
Hostnqn: "nqn.2014-08.org.nvmexpress:uuid:feb98abe-d51f-40c8-b348-2753f3571d3c",
},
controller,
nil,
[]string{`{"id":0,"error":{"code":0,"message":""},"result":[]}`},
codes.Unknown,
Expand All @@ -87,15 +69,7 @@ func TestBackEnd_CreateNVMfRemoteController(t *testing.T) {
},
{
"valid request with error code from SPDK response",
&pb.NVMfRemoteController{
Id: &pc.ObjectKey{Value: "OpiNvme8"},
Trtype: pb.NvmeTransportType_NVME_TRANSPORT_TCP,
Adrfam: pb.NvmeAddressFamily_NVMF_ADRFAM_IPV4,
Traddr: "127.0.0.1",
Trsvcid: 4444,
Subnqn: "nqn.2016-06.io.spdk:cnode1",
Hostnqn: "nqn.2014-08.org.nvmexpress:uuid:feb98abe-d51f-40c8-b348-2753f3571d3c",
},
controller,
nil,
[]string{`{"id":%d,"error":{"code":1,"message":"myopierr"},"result":[]}`},
codes.Unknown,
Expand All @@ -104,37 +78,17 @@ func TestBackEnd_CreateNVMfRemoteController(t *testing.T) {
},
{
"valid request with valid SPDK response",
&pb.NVMfRemoteController{
Id: &pc.ObjectKey{Value: "OpiNvme8"},
Trtype: pb.NvmeTransportType_NVME_TRANSPORT_TCP,
Adrfam: pb.NvmeAddressFamily_NVMF_ADRFAM_IPV4,
Traddr: "127.0.0.1",
Trsvcid: 4444,
Subnqn: "nqn.2016-06.io.spdk:cnode1",
Hostnqn: "nqn.2014-08.org.nvmexpress:uuid:feb98abe-d51f-40c8-b348-2753f3571d3c",
},
&pb.NVMfRemoteController{
Id: &pc.ObjectKey{Value: "OpiNvme8"},
Trtype: pb.NvmeTransportType_NVME_TRANSPORT_TCP,
Adrfam: pb.NvmeAddressFamily_NVMF_ADRFAM_IPV4,
Traddr: "127.0.0.1",
Trsvcid: 4444,
Subnqn: "nqn.2016-06.io.spdk:cnode1",
Hostnqn: "nqn.2014-08.org.nvmexpress:uuid:feb98abe-d51f-40c8-b348-2753f3571d3c",
},
controller,
controller,
[]string{`{"id":%d,"error":{"code":0,"message":""},"result":["my_remote_nvmf_bdev"]}`},
codes.OK,
"",
true,
},
}

// start GRPC mockup server
ctx := context.Background()
conn, err := grpc.DialContext(ctx, "", grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithContextDialer(dialer()))
if err != nil {
log.Fatal(err)
}
ctx, conn := startGrpcMockupServer()

defer func(conn *grpc.ClientConn) {
err := conn.Close()
if err != nil {
Expand All @@ -143,14 +97,8 @@ func TestBackEnd_CreateNVMfRemoteController(t *testing.T) {
}(conn)
client := pb.NewNVMfRemoteControllerServiceClient(conn)

// start SPDK mockup server
if err := os.RemoveAll(*rpcSock); err != nil {
log.Fatal(err)
}
ln, err := net.Listen("unix", *rpcSock)
if err != nil {
log.Fatal("listen error:", err)
}
ln := startSpdkMockupServer()

defer func(ln net.Listener) {
err := ln.Close()
if err != nil {
Expand Down Expand Up @@ -210,12 +158,8 @@ func TestBackEnd_NVMfRemoteControllerReset(t *testing.T) {
},
}

// start GRPC mockup server
ctx := context.Background()
conn, err := grpc.DialContext(ctx, "", grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithContextDialer(dialer()))
if err != nil {
log.Fatal(err)
}
ctx, conn := startGrpcMockupServer()

defer func(conn *grpc.ClientConn) {
err := conn.Close()
if err != nil {
Expand Down Expand Up @@ -337,12 +281,8 @@ func TestBackEnd_ListNVMfRemoteControllers(t *testing.T) {
},
}

// start GRPC mockup server
ctx := context.Background()
conn, err := grpc.DialContext(ctx, "", grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithContextDialer(dialer()))
if err != nil {
log.Fatal(err)
}
ctx, conn := startGrpcMockupServer()

defer func(conn *grpc.ClientConn) {
err := conn.Close()
if err != nil {
Expand All @@ -351,14 +291,8 @@ func TestBackEnd_ListNVMfRemoteControllers(t *testing.T) {
}(conn)
client := pb.NewNVMfRemoteControllerServiceClient(conn)

// start SPDK mockup server
if err := os.RemoveAll(*rpcSock); err != nil {
log.Fatal(err)
}
ln, err := net.Listen("unix", *rpcSock)
if err != nil {
log.Fatal("listen error:", err)
}
ln := startSpdkMockupServer()

defer func(ln net.Listener) {
err := ln.Close()
if err != nil {
Expand Down Expand Up @@ -468,12 +402,8 @@ func TestBackEnd_GetNVMfRemoteController(t *testing.T) {
},
}

// start GRPC mockup server
ctx := context.Background()
conn, err := grpc.DialContext(ctx, "", grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithContextDialer(dialer()))
if err != nil {
log.Fatal(err)
}
ctx, conn := startGrpcMockupServer()

defer func(conn *grpc.ClientConn) {
err := conn.Close()
if err != nil {
Expand All @@ -482,14 +412,8 @@ func TestBackEnd_GetNVMfRemoteController(t *testing.T) {
}(conn)
client := pb.NewNVMfRemoteControllerServiceClient(conn)

// start SPDK mockup server
if err := os.RemoveAll(*rpcSock); err != nil {
log.Fatal(err)
}
ln, err := net.Listen("unix", *rpcSock)
if err != nil {
log.Fatal("listen error:", err)
}
ln := startSpdkMockupServer()

defer func(ln net.Listener) {
err := ln.Close()
if err != nil {
Expand Down Expand Up @@ -552,12 +476,8 @@ func TestBackEnd_NVMfRemoteControllerStats(t *testing.T) {
},
}

// start GRPC mockup server
ctx := context.Background()
conn, err := grpc.DialContext(ctx, "", grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithContextDialer(dialer()))
if err != nil {
log.Fatal(err)
}
ctx, conn := startGrpcMockupServer()

defer func(conn *grpc.ClientConn) {
err := conn.Close()
if err != nil {
Expand All @@ -566,14 +486,8 @@ func TestBackEnd_NVMfRemoteControllerStats(t *testing.T) {
}(conn)
client := pb.NewNVMfRemoteControllerServiceClient(conn)

// start SPDK mockup server
if err := os.RemoveAll(*rpcSock); err != nil {
log.Fatal(err)
}
ln, err := net.Listen("unix", *rpcSock)
if err != nil {
log.Fatal("listen error:", err)
}
ln := startSpdkMockupServer()

defer func(ln net.Listener) {
err := ln.Close()
if err != nil {
Expand Down Expand Up @@ -675,12 +589,8 @@ func TestBackEnd_DeleteNVMfRemoteController(t *testing.T) {
},
}

// start GRPC mockup server
ctx := context.Background()
conn, err := grpc.DialContext(ctx, "", grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithContextDialer(dialer()))
if err != nil {
log.Fatal(err)
}
ctx, conn := startGrpcMockupServer()

defer func(conn *grpc.ClientConn) {
err := conn.Close()
if err != nil {
Expand All @@ -689,14 +599,8 @@ func TestBackEnd_DeleteNVMfRemoteController(t *testing.T) {
}(conn)
client := pb.NewNVMfRemoteControllerServiceClient(conn)

// start SPDK mockup server
if err := os.RemoveAll(*rpcSock); err != nil {
log.Fatal(err)
}
ln, err := net.Listen("unix", *rpcSock)
if err != nil {
log.Fatal("listen error:", err)
}
ln := startSpdkMockupServer()

defer func(ln net.Listener) {
err := ln.Close()
if err != nil {
Expand Down
Loading