Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update oras.Pack to comply with image-spec v1.1.0-rc4 #532

Closed
Wwwsylvia opened this issue Jul 3, 2023 · 0 comments · Fixed by #550
Closed

Update oras.Pack to comply with image-spec v1.1.0-rc4 #532

Wwwsylvia opened this issue Jul 3, 2023 · 0 comments · Fixed by #550
Labels
enhancement New feature or request
Milestone
v2.3.0

Comments

@Wwwsylvia
Copy link
Member

Wwwsylvia commented Jul 3, 2023 •
edited
Loading

We need to update oras.Pack to conform to the following requirements introduced by image-spec v1.1.0-rc4:

  • Use the empty descriptor for config if none is specified
  • Use the empty descriptor as the single layer if none is specified
  • Set the artifactType field in the image manifest

oras-go/pack.go

Line 78 in 6b5bd4b

func Pack(ctx context.Context, pusher content.Pusher, artifactType string, blobs []ocispec.Descriptor, opts PackOptions) (ocispec.Descriptor, error) {

@Wwwsylvia Wwwsylvia added the enhancement New feature or request label Jul 3, 2023
@Wwwsylvia Wwwsylvia added this to the v2.3.0 milestone Jul 3, 2023
@Wwwsylvia Wwwsylvia mentioned this issue Jul 3, 2023
Closed
@Wwwsylvia Wwwsylvia mentioned this issue Jul 12, 2023
Merged
Wwwsylvia added a commit that referenced this issue Jul 21, 2023
@Wwwsylvia
feat: add a PackOption to support packing image manifests that confor…
9b52269 
…m to image-spec v1.1.0-rc4 (#550)

1. Introduce `PackOptions.PackManifestType`
2. Introduce `DefaultPackOptions`

Resolves: #532
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia Wwwsylvia mentioned this issue Aug 7, 2023
Merged
Wwwsylvia added a commit that referenced this issue Aug 7, 2023
@Wwwsylvia
fix: pack should not set artifactType when config is specified (#565)
bbe92af 
Related issue: #532 
Related discussion:
oras-project/oras#1011 (comment)

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
This was referenced Aug 21, 2023
Merged
Closed
Wwwsylvia added a commit that referenced this issue Aug 22, 2023
@Wwwsylvia
refactor: add PackManifest and deprecate Pack (#570)
e6d40b6 
This PR refactors `oras.Pack` that was updated by #532.

1. Move the support of Image Manifest `v1.1.0-rc4` to `PackManifest`
2. Deprecate `Pack`

Resolves: #568
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
ORAS Project Board-2023
Status: Done
Milestone
v2.3.0
1 participant
@Wwwsylvia