Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Re-visit the deprecation design of oras.Pack #568

Closed
Wwwsylvia opened this issue Aug 9, 2023 · 0 comments · Fixed by #570
Closed

Re-visit the deprecation design of oras.Pack #568

Wwwsylvia opened this issue Aug 9, 2023 · 0 comments · Fixed by #570
Assignees
@Wwwsylvia
Labels
enhancement New feature or request
Milestone
v2.3.0

Comments

@Wwwsylvia
Copy link
Member

Wwwsylvia commented Aug 9, 2023 •
edited
Loading

Recently we introduced a new PackOption called PackManifestTypeImageV1_1_0_RC2 for oras.Pack but marked it as deprecated (See #532).
This might not be appropriate as it will cause linter error on the caller side.
We need to re-visit the design for oras.Pack.
@Wwwsylvia Wwwsylvia added the enhancement New feature or request label Aug 9, 2023
@Wwwsylvia Wwwsylvia added this to the v2.3.0 milestone Aug 9, 2023
@Wwwsylvia Wwwsylvia self-assigned this Aug 9, 2023
@Wwwsylvia Wwwsylvia mentioned this issue Aug 21, 2023
Merged
Wwwsylvia added a commit that referenced this issue Aug 22, 2023
@Wwwsylvia
refactor: add PackManifest and deprecate Pack (#570)
e6d40b6 
This PR refactors `oras.Pack` that was updated by #532.

1. Move the support of Image Manifest `v1.1.0-rc4` to `PackManifest`
2. Deprecate `Pack`

Resolves: #568
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Wwwsylvia Wwwsylvia

Labels
enhancement New feature or request
Projects
No open projects
ORAS Project Board-2023
Status: Done
Milestone
v2.3.0
Development

Successfully merging a pull request may close this issue.

refactor: add PackManifest and deprecate Pack Wwwsylvia/oras-go
1 participant
@Wwwsylvia