-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rename ErrSkipDesc
to SkipNode
#634
Comments
@shizhMSFT I do like the name |
|
Maybe |
For API choices it always easier when we look at it in the context of code. Can we write up a small code block that would use SkipNode or skipDescriptor? |
You see a use of |
The name |
|
ErrSkipDesc
to SkipDesc
ErrSkipDesc
to SkipNode
Resolves #634 Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
#631 exports
errSkipDesc
toErrSkipDesc
so that copy can be skipped for mounting. However,ErrSkipDesc
is not a real error that should be returned by any function.I have looked into the golang built-in package
io/fs
and foundSkipAll
andSkipDir
. To have consistent naming as the build-in packages, I propose that we should renameErrSkipDesc
toSkipDesc
SkipNode
(as discussed in comment section).@Wwwsylvia @ktarplee Any comments?
The text was updated successfully, but these errors were encountered: