fix: rename ErrSkipDesc to SkipNode #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxiaoxuan273
requested review from
sajayantony,
shizhMSFT,
SteveLasker and
Wwwsylvia
as code owners
ktarplee
reviewed
Nov 16, 2023
|
I also think we should add a sentence to the documentation for the |
Wwwsylvia
reviewed
Nov 17, 2023
Added a doc comment in the |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
=======================================
Coverage 75.19% 75.20%
=======================================
Files 59 59
Lines 5427 5473 +46
=======================================
+ Hits 4081 4116 +35
- Misses 992 1001 +9
- Partials 354 356 +2 ☔ View full report in Codecov by Sentry. |
wangxiaoxuan273
force-pushed
the
rename-var
branch
from
ac9f874 to
8354612
Compare
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
wangxiaoxuan273
force-pushed
the
rename-var
branch
from
8354612 to
dff6b51
Compare
Wwwsylvia
reviewed
Nov 20, 2023
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #634