Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: support Image Index with a subject #548

Merged
merged 14 commits into from
Jul 12, 2023
Merged

feat: support Image Index with a subject #548

merged 14 commits into from
Jul 12, 2023

Conversation

Wwwsylvia
Copy link
Member

Resolves: #531

Wwwsylvia added 13 commits July 5, 2023 17:10
@Wwwsylvia
update Successors()
64c6314 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
add manifest parse method
cefa823 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
move function and add TODOs
872c9e1 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
test platform
e277cb6 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
improve platform test
69a33e2 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
test successors
1062ed7 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
add comments
b889429 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
revert successors
e6c7c68 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
add parser
56b8c3a 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
test extended copy
35926d5 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
test extended copy
442e159 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
TODOs
0f9f01b 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
fix and improve tests
f5578ca 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
shizhMSFT
shizhMSFT reviewed Jul 10, 2023
View reviewed changes
@Wwwsylvia
address comments
4a53a8a 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit f0a9c59 into oras-project:main Jul 12, 2023
@Wwwsylvia Wwwsylvia deleted the handle_subject branch July 12, 2023 03:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Image Index with a subject
2 participants
@Wwwsylvia @shizhMSFT