Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: support Image Index with a subject #548

Merged
merged 14 commits into from
Jul 12, 2023
Merged

feat: support Image Index with a subject #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
64c6314
update Successors()
Wwwsylvia Jul 5, 2023
cefa823
add manifest parse method
Wwwsylvia Jul 5, 2023
872c9e1
move function and add TODOs
Wwwsylvia Jul 6, 2023
e277cb6
test platform
Wwwsylvia Jul 7, 2023
69a33e2
improve platform test
Wwwsylvia Jul 7, 2023
1062ed7
test successors
Wwwsylvia Jul 7, 2023
b889429
add comments
Wwwsylvia Jul 7, 2023
e6c7c68
revert successors
Wwwsylvia Jul 7, 2023
56b8c3a
add parser
Wwwsylvia Jul 7, 2023
35926d5
test extended copy
Wwwsylvia Jul 7, 2023
442e159
test extended copy
Wwwsylvia Jul 7, 2023
0f9f01b
TODOs
Wwwsylvia Jul 7, 2023
f5578ca
fix and improve tests
Wwwsylvia Jul 10, 2023
4a53a8a
address comments
Wwwsylvia Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions content/graph.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,18 +75,33 @@ func Successors(ctx context.Context, fetcher Fetcher, node ocispec.Descriptor) (
}
nodes = append(nodes, manifest.Config)
return append(nodes, manifest.Layers...), nil
case docker.MediaTypeManifestList, ocispec.MediaTypeImageIndex:
case docker.MediaTypeManifestList:
content, err := FetchAll(ctx, fetcher, node)
if err != nil {
return nil, err
}

// docker manifest list and oci index are equivalent for successors.
// OCI manifest index schema can be used to marshal docker manifest list
var index ocispec.Index
if err := json.Unmarshal(content, &index); err != nil {
return nil, err
}
return index.Manifests, nil
case ocispec.MediaTypeImageIndex:
content, err := FetchAll(ctx, fetcher, node)
if err != nil {
return nil, err
}

var index ocispec.Index
if err := json.Unmarshal(content, &index); err != nil {
return nil, err
}
var nodes []ocispec.Descriptor
if index.Subject != nil {
nodes = append(nodes, *index.Subject)
}
return append(nodes, index.Manifests...), nil
case spec.MediaTypeArtifactManifest:
content, err := FetchAll(ctx, fetcher, node)
if err != nil {
Expand Down
Loading