Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: namespace should not be required in List API #796

Merged
merged 3 commits into from
Dec 13, 2021
Merged

fix: namespace should not be required in List API #796

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9e4cc6
fix: namespace should not be required in List API
vancanhuit Dec 12, 2021
aa91078
test: update
vancanhuit Dec 12, 2021
635962c
simplify test type conversion
zepatrik Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ node_modules/
coverage.txt
dist/
**/*.sqlite
.vscode/
Empty file removed internal/e2e/Test
View file
Open in desktop
Empty file.
6 changes: 4 additions & 2 deletions internal/e2e/sdk_client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ func (c *sdkClient) deleteTuple(t require.TestingT, r *relationtuple.InternalRel
}

func compileParams(q *relationtuple.RelationQuery, opts []x.PaginationOptionSetter) *read.GetRelationTuplesParams {
params := read.NewGetRelationTuplesParams().WithNamespace(q.Namespace)
params := read.NewGetRelationTuplesParams().WithNamespace(&q.Namespace)
if q.Relation != "" {
params = params.WithRelation(&q.Relation)
}
Expand Down Expand Up @@ -213,7 +213,9 @@ func (c *sdkClient) expand(t require.TestingT, r *relationtuple.SubjectSet, dept
WithNamespace(r.Namespace).
WithObject(r.Object).
WithRelation(r.Relation).
WithMaxDepth(int64(depth)),
WithMaxDepth(func(n int64) *int64 {
return &n
}(int64(depth))),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
WithMaxDepth(func(n int64) *int64 {
return &n
}(int64(depth))),
WithMaxDepth(pointerx.Int64(int64(depth))),

)
require.NoError(t, err)
return buildTree(t, resp.Payload)
Expand Down
34 changes: 34 additions & 0 deletions internal/httpclient/client/read/get_check_parameters.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 16 additions & 9 deletions internal/httpclient/client/read/get_expand_parameters.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 16 additions & 9 deletions internal/httpclient/client/read/get_relation_tuples_parameters.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 34 additions & 0 deletions internal/httpclient/client/read/post_check_parameters.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 1 addition & 13 deletions internal/httpclient/models/expand_tree.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions internal/httpclient/models/get_relation_tuples_response.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions internal/httpclient/models/internal_relation_tuple.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions internal/httpclient/models/patch_delta.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions internal/httpclient/models/relation_query.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion internal/relationtuple/read_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ type getRelationsParams struct {
// Namespace of the Relation Tuple
//
// in: query
// required: true
Namespace string `json:"namespace"`

// Object of the Relation Tuple
Expand Down
Loading