Revert "Remove all use of mint tokens" #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 6, 2022 11:25
This was referenced May 7, 2022
maurolacy
force-pushed
the
enable-mint-bindings
branch
from
cce1047 to
5030d71
Compare
Rename EstimatePriceResponse to SwapResponse for consistency / clarity
ethanfrey
approved these changes
May 9, 2022
| fn build_denom(&self, contract: &Addr, sub_denom: &str) -> String { | ||
| // TODO: validation assertion on the full denom. | ||
| // https://github.com/cosmos/cosmos-sdk/blob/2646b474c7beb0c93d4fafd395ef345f41afc251/types/coin.go#L706-L711 | ||
| // Plus, the address must not contain the separator ('/') string. |
There was a problem hiding this comment.
I would minimally assert some limits... len >= 2, len <= 127, no /
mergify bot
pushed a commit
to osmosis-labs/osmosis
that referenced
this pull request
May 16, 2022
Closes / Related to: #1029 ## What is the purpose of the change Re-instate the CoswmWasm message handlers for Mint and FullDenom. Related to osmosis-labs/bindings#25 on the Rust side. ## Brief change log - Uncomment the Mint-related code. - Implemented `Mint` using `TokenFactory`. - Implemented `FullDenom` in terms of `TokenFactory`. ## Testing and Verifying Uncommented and adapted already existing tests. ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? (yes. For the CosmWasm side) - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? (will do) - How is the feature or change documented? (not documented)
larry0x
pushed a commit
to larry0x/wasmd
that referenced
this pull request
Jul 17, 2023
Closes / Related to: CosmWasm#1029 ## What is the purpose of the change Re-instate the CoswmWasm message handlers for Mint and FullDenom. Related to osmosis-labs/bindings#25 on the Rust side. ## Brief change log - Uncomment the Mint-related code. - Implemented `Mint` using `TokenFactory`. - Implemented `FullDenom` in terms of `TokenFactory`. ## Testing and Verifying Uncommented and adapted already existing tests. ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? (yes. For the CosmWasm side) - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? (will do) - How is the feature or change documented? (not documented)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c0ea5b7.
This re-instates the mint / full-denom mintings.