Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Epic] Token Factory Module #1029

Closed
5 of 6 tasks
ValarDragon opened this issue Mar 3, 2022 · 5 comments
Closed
5 of 6 tasks

[Epic] Token Factory Module #1029

ValarDragon opened this issue Mar 3, 2022 · 5 comments

Comments

@ValarDragon
Copy link
Member

ValarDragon commented Mar 3, 2022

The token factory module is a module that will enable new native tokens to be minted on Osmosis, with well prefixed names. This is important for cosmwasm applications on osmosis to thrive.

@ValarDragon ValarDragon moved this from 🔍 Needs Review to 🕒 Todo in Osmosis Chain Development Mar 3, 2022
@ValarDragon ValarDragon moved this to 🔍 Needs Review in Osmosis Chain Development Mar 3, 2022
@sunnya97
Copy link
Collaborator

sunnya97 commented Mar 7, 2022

We should add checks that prevent force transferring or burning from module accounts.

I think maybe to be maximally safe, just deactivate force transferring altogether, and only allow burning of tokens that are in the triggering account.

@sunnya97
Copy link
Collaborator

sunnya97 commented Apr 5, 2022

Let's go ahead and reduce the scope such that minting and burning can only happen in the triggering account.

@sunnya97
Copy link
Collaborator

sunnya97 commented Apr 5, 2022

That way we can ship it faster

@p0mvn
Copy link
Member

p0mvn commented May 4, 2022

I'm cleaning up the epics and seeing some checkboxes without issues. @sunnya97 @ValarDragon could you update the epic to cross out the completed items and create issues for items that still need work. Thank you!

@p0mvn p0mvn moved this from 🕒 Todo to 🏃 In Progress in Osmosis Chain Development May 4, 2022
mergify bot pushed a commit that referenced this issue May 16, 2022
Closes / Related to: #1029

## What is the purpose of the change

Re-instate the CoswmWasm message handlers for Mint and FullDenom. Related to osmosis-labs/bindings#25 on the Rust side.


## Brief change log

  - Uncomment the Mint-related code.
  - Implemented `Mint` using `TokenFactory`.
  - Implemented `FullDenom` in terms of `TokenFactory`.

## Testing and Verifying

Uncommented and adapted already existing tests.


## Documentation and Release Note

  - Does this pull request introduce a new feature or user-facing behavior changes? (yes. For the CosmWasm side)
  - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? (will do)
  - How is the feature or change documented? (not documented)
@mattverse
Copy link
Member

Closing this issue to replace with issues with more details and specifics

Repository owner moved this from In Progress🏃 to Done ✅ in Osmosis Chain Development May 31, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants