Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix mbari_wec.launch.py arguments #164

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Fix mbari_wec.launch.py arguments #164

merged 1 commit into from
Sep 19, 2023

Conversation

andermi
Copy link
Collaborator

@andermi andermi commented Sep 19, 2023

override arguments weren't displayed in -s option of launch file
typo in inc wave override description

@andermi
override arguments weren't displayed in -s option of launch file; t…
0f8c606 
…ypo in inc wave override description

Signed-off-by: Michael Anderson <anderson@mbari.org>
hamilton8415
hamilton8415 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@hamilton8415 hamilton8415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, -s shows options. Tested with experiment_comparison_select.launch.py

But, I remember it working yesterday too, so consider the source. :)

@andermi andermi merged commit cb380a8 into main Sep 19, 2023
3 checks passed
@andermi andermi deleted the andermi/fix_launch_args branch September 19, 2023 20:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hamilton8415 hamilton8415 hamilton8415 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andermi @hamilton8415