Change WAMIT data to mbari_snl version #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The monochromatic test cases indicate that updating these hydrodynamic coefficients brings the gazebo results a bit closer to the WecSim simulator results for this system, which use the mbari_snl hydrodynamic coefficients. The comparison shown below is a particularly good example from the set of monochromatic runs (various amplitudes and periods).
|
andermi
approved these changes
Dec 5, 2023
|
Yes, I considered including that. In my typical fashion it's "results oriented", but it needs to be archived somewhere so I'll put it in and maybe add some notes to the beginning to explain how it could be improved. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple change from one set of buoy hydrodynamic coefficients for the buoy to an updated set that was computed by the Sandia group. This new data is contained in files called mbari_snl_IR.1, mbari_snl_JR.2, mbari_snl.1, and mbari_snl_3. The WAMIT output was supplied in an .h5 file (included but not used in this repository), and converted to the .1/.3 data format by auxiliary scripts.