Skip to content

Distribute niosh docker layers #582

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Sep 1, 2020
Merged

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Aug 26, 2020

I've moved the NIOSH tiles out of the SubT Tech Repo in order to download them into separate docker layers. This will let us push new docker images to ECR by avoiding a single layer that is too large.

Nate Koenig added 2 commits August 26, 2020 15:11
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested review from iche033 and caguero and removed request for iche033 August 27, 2020 18:47
nkoenig and others added 3 commits September 1, 2020 05:42
* Publish robot name and type information

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* adding in marsupial pairs

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig
Copy link
Contributor Author

nkoenig commented Sep 1, 2020

This also renames NIOSH Segment 01 tiles as NIOSH SR Course and NIOSH Segment 02 as NIOSH EX Course.

Fuel has been updated as well.

Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I only have one question: Are NIOSH SR Course Shell and NIOSH EX Course Shell in Fuel? I can't find them...I see the NIOSH Segment 01 Shell and NIOSH Segment 02 Shell. Do we need to rename them?

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig
Copy link
Contributor Author

nkoenig commented Sep 1, 2020

@nkoenig nkoenig merged commit 60aeb72 into master Sep 1, 2020
@nkoenig nkoenig deleted the distribute_niosh_docker_layers branch December 10, 2020 22:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants