Skip to content

Remove the model database from cloudsim_bridge image because it doesn't need it for anything. #754

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

peci1
Copy link
Collaborator

@peci1 peci1 commented Jan 18, 2021

This will get the overall size of bridge image down to 8 GB (from 12 GB). Smaller images are said to be faster in Docker (not sure about the newest versions, though).

As the models are only actually needed in the cloudsim_sim image (if I'm not missing something), the bridge container could then become the suggested base of solution images (and e.g. subt_hello_world images).

This is another take at #700. It can be combined with #749 to further decrease size of the image.

@nkoenig nkoenig merged commit 8c444a3 into osrf:master Jan 20, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants