Skip to content

Miscellaneous Fixes for Submitted Models #921

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 14, 2021
Merged

Miscellaneous Fixes for Submitted Models #921

merged 3 commits into from
Jun 14, 2021

Conversation

acschang
Copy link
Contributor

@acschang acschang commented May 18, 2021 •
edited
Loading

Includes:

  • Documentation cleanup on MARBLE Husky SC1
  • LIDAR parameter adjustments/fixes on MARBLE Husky SC1, SC3, and SC4
  • PicoFlexx intrinsic parameters on CERBERUS Gagarin and MARBLE QAV500 models

@acschang acschang changed the title Miscellaneous Fixes for Submitted Models WIP: Miscellaneous Fixes for Submitted Models May 18, 2021
@peci1
Copy link
Collaborator

peci1 commented May 23, 2021

Could you please also add the camera intrinsics for DTR? #909

@peci1
Copy link
Collaborator

peci1 commented May 24, 2021

Never mind, I added the DTR intrinsics in #930.

@nkoenig
Copy link
Contributor

nkoenig commented May 25, 2021

@acschang , are you okay with merging this one?

@nkoenig nkoenig changed the base branch from master to final_event May 27, 2021 15:30
@acschang
Copy link
Contributor Author

@acschang , are you okay with merging this one?

Yes, we can go ahead and merge this. We can make subsequent PRs for other minor changes.

@acschang acschang changed the title WIP: Miscellaneous Fixes for Submitted Models Miscellaneous Fixes for Submitted Models Jun 11, 2021
@nkoenig nkoenig merged commit a18f966 into final_event Jun 14, 2021
@nkoenig nkoenig deleted the submitted_models/misc_fixes branch September 27, 2021 17:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nkoenig nkoenig nkoenig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acschang @peci1 @nkoenig