Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade project tooling to PHP 8.2 #300

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Upgrade project tooling to PHP 8.2 #300

merged 3 commits into from
Apr 8, 2024

Conversation

agentrickard
Copy link
Contributor

Description

Update composer requirements and github task runners to use PHP 8.2

To Test

  • Tests are automated, but should be repeated locally
  • Checkout this branch and
rm -rf vendor
rm composer.lock
composer install
composer test
composer phpstan
composer check-style
composer fix-style

All should run without issue. However, I am getting this error locally using PHP 8.2.16:

composer check-style

> vendor/bin/php-cs-fixer check
PHP Fatal error:  Uncaught TypeError: PhpCsFixer\FixerFactory::registerFixer(): Argument #1 ($fixer) must be of type PhpCsFixer\Fixer\FixerInterface, PhpCsFixer\Fixer\ClassNotation\ProtectedToPrivateFixer given, called in /Users/rickard/Sites/drupal-rector/vendor/friendsofphp/php-cs-fixer/src/FixerFactory.php on line 100 and defined in /Users/rickard/Sites/drupal-rector/vendor/friendsofphp/php-cs-fixer/src/FixerFactory.php:123
Stack trace:
#0 /Users/rickard/Sites/drupal-rector/vendor/friendsofphp/php-cs-fixer/src/FixerFactory.php(100): PhpCsFixer\FixerFactory->registerFixer(Object(PhpCsFixer\Fixer\ClassNotation\ProtectedToPrivateFixer), false)
#1 /Users/rickard/Sites/drupal-rector/vendor/friendsofphp/php-cs-fixer/src/Console/Command/DescribeCommand.php(79): PhpCsFixer\FixerFactory->registerBuiltInFixers()
#2 /Users/rickard/Sites/drupal-rector/vendor/friendsofphp/php-cs-fixer/src/Console/Application.php(56): PhpCsFixer\Console\Command\DescribeCommand->__construct()
#3 /Users/rickard/Sites/drupal-rector/vendor/friendsofphp/php-cs-fixer/php-cs-fixer(101): PhpCsFixer\Console\Application->__construct()
#4 /Users/rickard/Sites/drupal-rector/vendor/bin/php-cs-fixer(119): include('/Users/rickard/...')
#5 {main}
  thrown in /Users/rickard/Sites/drupal-rector/vendor/friendsofphp/php-cs-fixer/src/FixerFactory.php on line 123

Drupal.org issue

https://www.drupal.org/project/rector/issues/3437018

@bbrala
Copy link
Collaborator

bbrala commented Apr 7, 2024

Seems this is the issue:

symplify/rule-doc-generator#12

@bbrala bbrala merged commit b5ad678 into main Apr 8, 2024
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants