Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update AbstractFixer.php add missing interface #12

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

bbrala
Copy link
Contributor

@bbrala bbrala commented Apr 7, 2024

@TomasVotruba
Copy link
Member

Thank you 👍 makes sense

@TomasVotruba TomasVotruba enabled auto-merge (squash) April 7, 2024 18:50
@TomasVotruba
Copy link
Member

Could fix the test? It will need similar stub for FixerInterface as well

@bbrala
Copy link
Contributor Author

bbrala commented Apr 8, 2024

Sure, give me a min ;)

auto-merge was automatically disabled April 8, 2024 06:51

Head branch was pushed to by a user without write access

@bbrala
Copy link
Contributor Author

bbrala commented Apr 8, 2024

Added the testing interface.

Could you whitelist me for tests? I've been working with rector also a while ;p

@TomasVotruba
Copy link
Member

Could you whitelist me for tests? I've been working with rector also a while ;p

I wish I could 🙏 That's Github feature to protect from missusing CI. It needs at least one accepted merge per project to trigger CI automatically.

All good now 👍

@TomasVotruba TomasVotruba merged commit 30d9afa into symplify:main Apr 8, 2024
6 checks passed
@bbrala
Copy link
Contributor Author

bbrala commented Apr 8, 2024

Fair enough, thanks :)

@bbrala bbrala deleted the patch-1 branch April 8, 2024 08:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants