DEPR: remove Index._is backward_compat_public_numeric_index #50052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
Index._is_backward_compat_public_numeric_index
branch
4 times, most recently
from
fd768f5 to
861ee2e
Compare
topper-123
force-pushed
the
Index._is_backward_compat_public_numeric_index
branch
2 times, most recently
from
c9f6171 to
8f846c9
Compare
topper-123
force-pushed
the
Index._is_backward_compat_public_numeric_index
branch
from
8f846c9 to
5c96039
Compare
topper-123
force-pushed
the
Index._is_backward_compat_public_numeric_index
branch
from
5c96039 to
21317ba
Compare
|
Could someone take a review? E.g. @jbrockmendel or @mroeschke? I've rebased this after #49560 has been merged. After #49560 and this will have been merged, the removal of Int/Uint/Float64Index should become quite straight forward. |
mroeschke
reviewed
Jan 15, 2023
pandas/core/indexes/base.py
Outdated
| @@ -395,7 +392,6 @@ def _outer_indexer( | |||
| # Whether this index is a NumericIndex, but not a Int64Index, Float64Index, | |||
| # UInt64Index or RangeIndex. Needed for backwards compat. Remove this attribute and | |||
| # associated code in pandas 2.0. | |||
There was a problem hiding this comment.
Guessing this comment isn't needed anymore?
There was a problem hiding this comment.
Yeah…I’l wait a bit to see if there are more comments coming, then I’ll update.
There was a problem hiding this comment.
I’ve updated this now.
mroeschke
approved these changes
Jan 16, 2023
|
Thanks @topper-123 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the attribute
Index._is backward_compat_public_numeric_indexand related stuff. This is the last PR before actually removing Int64/UInt64/Float64Index from the code base.This PR builds on top of #49560 (which is not yet merged), so please exclude the first commit from review of this PR.
I'd also truly appreciate if someone could review #49560, as it's quite a heavy PR with lots of dtype changes.