-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
DEPR: Remove int64 uint64 float64 index tests #50479
Closed
topper-123
wants to merge
8
commits into
pandas-dev:main
from
topper-123:remove_int64_uint64_float64_index_tests
Closed
DEPR: Remove int64 uint64 float64 index tests #50479
topper-123
wants to merge
8
commits into
pandas-dev:main
from
topper-123:remove_int64_uint64_float64_index_tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab5f69c
to
54fe9b5
Compare
54fe9b5
to
368ca06
Compare
needs rebase |
Yeah, this builds on top of #49560. If I can get that PR in, I will update this (and proceed with other remaining Int/Uint/Float64Index removal. |
368ca06
to
bc7911e
Compare
bc7911e
to
4731a95
Compare
This was referenced Jan 16, 2023
Superseded by various other PRs. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates various tests that currently use Int64Index/UInt64Index/Float64Index to instead use
Index
with the relevant dtype (parametrized dtypes where relevant). Sections of the tests suite are changed in separate commits, so it will be easier to separate them out, if desired.This PR's first 3 commits correspond to #50052, which again build on #49560, which builds on #50195. Those 3 PRs are not part of this PR, but should ideally be treated as precursors for this PR, if possible.