-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
REF: Make concat not stateful. #59141
Conversation
| Change | Before [039edee0] <main> | After [0becd77e] <ref/concat> | Ratio | Benchmark (Parameter) |
|----------|----------------------------|---------------------------------|---------|--------------------------------------------------------------------------------------|
| - | 46.8±4μs | 41.8±0.1μs | 0.89 | join_merge.ConcatIndexDtype.time_concat_series('string[pyarrow]', 'has_na', 0, True) |
SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.
PERFORMANCE INCREASED. |
Since test are passing, going to merge. Happy to follow up if needed |
Hey, just a note that this has broken concat override in geopandas, where we're now hitting |
It was an intended consequence of the refactor given that To confirm it appears that geopandas overrides |
To ensure that we can correctly propagate custom metadata. That used to be an information about projection and an active geometry column, right now it is only active geometry column. Without that, the resulting GeoDataFrame would lose the track of active geometry and require manual re-assignment of active geometry. |
All the logic used to be held in a
_Concatenator
class. The statefullness wasn't really needed sinceconcat
is a one-shot method so broke it out into its functions