REF: Add back attr passing in concat by attribute #59195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Refactor
jbrockmendel
reviewed
Jul 7, 2024
| @@ -6017,16 +6017,17 @@ def __finalize__(self, other, method: str | None = None, **kwargs) -> Self: | |||
| object.__setattr__(self, name, getattr(other, name, None)) | |||
|
|
|||
| if method == "concat": | |||
| objs = kwargs["objs"] | |||
There was a problem hiding this comment.
Slightly more performant to define objs=other.objs once?
There was a problem hiding this comment.
Can we get rid of kwargs? Will this mess up for subclasssss?
There was a problem hiding this comment.
Slightly more performant to define objs=other.objs once?
Sure thing. Make sense
Can we get rid of kwargs? Will this mess up for subclasssss?
Looks generally unused but not exactly sure the scope of how this is used. I'd prefer to maybe do this in a separate change
|
Going to merge to fix geopandas CI downstream. Happy to follow up if needed |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #59141 (comment)