-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
feat: Add support for MongoDB databaseOptions
keys minPoolSize
, connectTimeoutMS
, socketTimeoutMS
, autoSelectFamily
, autoSelectFamilyAttemptTimeout
#9577
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.x.x #9577 +/- ##
=================================================
- Coverage 93.51% 93.50% -0.02%
=================================================
Files 186 186
Lines 14804 14804
=================================================
- Hits 13844 13842 -2
- Misses 960 962 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
databaseOptions
keys minPoolSize
, connectTimeoutMS
, socketTimeoutMS
databaseOptions
keys minPoolSize
, connectTimeoutMS
, socketTimeoutMS
, autoSelectFamily
, autoSelectFamilyAttemptTimeout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this PR is not a clone of the Parse Server 8 PR, as there are more options in this PR, is that correct, and if yes, why?
@mtrezza because since the Parse Server 8 PR, I found 2 more Mongo settings that are important. Ideally, I think 8 wouldn't validate These 2 new fields are really interesting and will help people migrate to Parse 7 as well. The tldr; is that the Node Mongo driver package released a breaking change in a minor release (v6.9) that switched the There's a discussion about this here: https://www.mongodb.com/community/forums/t/i-keep-getting-error-when-i-try-connecting-node-to-mongodb/243422/22?page=2 |
It would be great if you could add another PR for Parse Server 8 before we can merge this. The reason is that we aim to back-port identical code, to mitigate divergence in the branches, which would make them more difficult to maintain. |
Looks good! |
We'll merge this after Parse Server 8 release, so that it triggers a new Parse Server 7 release. |
@pocketcolin Thank you for the PRs, I'll go ahead and merge this, just mind that this won't be part of a Parse Server 7 release yet. But to make it easier for you, you can just point your |
# [7.5.0](7.4.0...7.5.0) (2025-03-12) ### Bug Fixes * LiveQueryServer crashes using cacheAdapter on disconnect from Redis 4 server ([#9615](#9615)) ([0769215](0769215)) * Push adapter not loading on some versions of Node 22 ([#9525](#9525)) ([5447c22](5447c22)) * Security upgrade node from 20.17.0-alpine3.20 to 20.18.2-alpine3.20 ([#9597](#9597)) ([6114cd9](6114cd9)) ### Features * Add support for MongoDB `databaseOptions` keys `minPoolSize`, `connectTimeoutMS`, `socketTimeoutMS`, `autoSelectFamily`, `autoSelectFamilyAttemptTimeout` ([#9577](#9577)) ([20f2071](20f2071))
🎉 This change has been released in version 7.5.0 |
Pull Request
Issue
NOTE: This is a clone of #9522 so that the update can go out in 7.x.x in addition to 8.
9523
Closes: 9523
Approach
As discussed in #9211, the decision was made to maintain a list of valid database options for the Parse config that can be passed to MongoDB. There are many options (46 in total) and this PR adds 3 more that I was using. This approach just follows the same approach used in #9213
Tasks