Skip to content

fix: LiveQueryServer crashes using cacheAdapter on disconnect from Redis 4 server #9615

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

Chilldev
Copy link
Contributor

Pull Request

Issue

Closes: #9432

Approach

Add empty handlers to redis client error, connect, reconnecting, ready events.

Copy link

Thanks for opening this pull request!

@Chilldev Chilldev changed the title Handle Redis createClient on error. Handle Redis createClient on error. (v7.x.x) Feb 20, 2025
@Chilldev Chilldev changed the title Handle Redis createClient on error. (v7.x.x) Fix: Redis 4 crash on disconnect. (v7.x.x) Feb 20, 2025
@Chilldev Chilldev changed the title Fix: Redis 4 crash on disconnect. (v7.x.x) fix: Redis 4 crash on disconnect. (v7.x.x) Feb 20, 2025
@mtrezza mtrezza linked an issue Feb 22, 2025 that may be closed by this pull request
@mtrezza mtrezza linked an issue Feb 22, 2025 that may be closed by this pull request
@mtrezza
Copy link
Member

mtrezza commented Feb 22, 2025

See #9616 (comment)

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.52%. Comparing base (79204f7) to head (8410e28).
Report is 3 commits behind head on release-7.x.x.

Additional details and impacted files
@@                Coverage Diff                @@
##           release-7.x.x    #9615      +/-   ##
=================================================
+ Coverage          93.50%   93.52%   +0.02%     
=================================================
  Files                186      186              
  Lines              14804    14819      +15     
=================================================
+ Hits               13842    13860      +18     
+ Misses               962      959       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtrezza mtrezza changed the title fix: Redis 4 crash on disconnect. (v7.x.x) fix: LiveQueryServer crashes using cacheAdapter on disconnect from Redis 4 server Feb 23, 2025
@mtrezza mtrezza merged commit 0769215 into parse-community:release-7.x.x Feb 24, 2025
29 of 30 checks passed
parseplatformorg pushed a commit that referenced this pull request Mar 12, 2025
# [7.5.0](7.4.0...7.5.0) (2025-03-12)

### Bug Fixes

* LiveQueryServer crashes using cacheAdapter on disconnect from Redis 4 server ([#9615](#9615)) ([0769215](0769215))
* Push adapter not loading on some versions of Node 22 ([#9525](#9525)) ([5447c22](5447c22))
* Security upgrade node from 20.17.0-alpine3.20 to 20.18.2-alpine3.20 ([#9597](#9597)) ([6114cd9](6114cd9))

### Features

* Add support for MongoDB `databaseOptions` keys `minPoolSize`, `connectTimeoutMS`, `socketTimeoutMS`, `autoSelectFamily`, `autoSelectFamilyAttemptTimeout` ([#9577](#9577)) ([20f2071](20f2071))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.5.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LiveQueryServer crashes when configured to run with Redis cacheAdapter
3 participants