Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FISH-10211 Document MVC Usage #524

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

Pandrex247
Copy link
Member

Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for preview-enterprise-6-docs-payara ready!

Name Link
🔨 Latest commit 13e3a5f
🔍 Latest deploy log https://app.netlify.com/sites/preview-enterprise-6-docs-payara/deploys/675b45c4edeed90008ca16d1
😎 Deploy Preview https://deploy-preview-524--preview-enterprise-6-docs-payara.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for preview-community-6-docs-payara ready!

Name Link
🔨 Latest commit 13e3a5f
🔍 Latest deploy log https://app.netlify.com/sites/preview-community-6-docs-payara/deploys/675b45c478a90a0008a794db
😎 Deploy Preview https://deploy-preview-524--preview-community-6-docs-payara.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
@Pandrex247 Pandrex247 added the Do Not Merge Do not merge this PR label Dec 3, 2024
@Pandrex247
Copy link
Member Author

Needs revisiting, the example from the blog isn't valid code.

Fixes the code, specifies where to place the xhtml files, and adds extra code resources which were only obliquely mentioned on the original blog.

Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
@Pandrex247 Pandrex247 removed the Do Not Merge Do not merge this PR label Dec 3, 2024
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
@Pandrex247 Pandrex247 requested a review from fturizo December 3, 2024 17:05
Pandrex247 and others added 2 commits December 5, 2024 14:12
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Copy link
Contributor

@fturizo fturizo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved the layout and some details, looks really good!

@fturizo fturizo merged commit 003ec68 into payara:main-6 Dec 12, 2024
9 checks passed
@Pandrex247 Pandrex247 deleted the FISH-10211-MVC-and-Krazo branch December 16, 2024 16:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants