Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

FISH-10211 MVC 2.1 and Krazo 3.0 #7089

Merged
merged 2 commits into from
Dec 5, 2024
Merged

FISH-10211 MVC 2.1 and Krazo 3.0 #7089

merged 2 commits into from
Dec 5, 2024

Conversation

Pandrex247
Copy link
Member

@Pandrex247 Pandrex247 commented Nov 26, 2024 •
edited
Loading

Description

Initial PoC of bundling the MVC 2.1 API and Krazo 3.0 as its implementation.

Important Info

Blockers

None

Testing

New tests

Added a sample

Testing Performed

I've built the server and started the admin console and nothing exploded.
Ran Payara through the Krazo TCK and testsuite modules: https://github.com/eclipse-ee4j/krazo/tree/3.0.1
Ran test sample against server-remote and micro-managed profiles

Testing Environment

Windows 11, Zulu JDK 11.0.25, Maven 3.9.9

Documentation

payara/Payara-Documentation#524

Notes for Reviewers

None

@Pandrex247
FISH-10211 PoC of MVC 2.1 and Krazo 3.0
7f5679b 
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
@Pandrex247 Pandrex247 changed the title FISH-10211 PoC of MVC 2.1 and Krazo 3.0 FISH-10211 MVC 2.1 and Krazo 3.0 Nov 26, 2024
@Pandrex247 Pandrex247 marked this pull request as ready for review December 2, 2024 09:26
@Pandrex247 Pandrex247 mentioned this pull request Dec 3, 2024
Merged
@Pandrex247
FISH-10211 Add sample
2d613ea 
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
@breakponchito breakponchito self-requested a review December 5, 2024 16:22
breakponchito
breakponchito approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I already tested and is working as expected

@Pandrex247 Pandrex247 merged commit 5d78710 into payara:main Dec 5, 2024
1 check passed
@Pandrex247 Pandrex247 deleted the FISH-10211-MVC-and-Krazo branch December 5, 2024 16:58
Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Dec 9, 2024
@Pandrex247
Revert "Merge pull request payara#7089 from Pandrex247/FISH-10211-MVC…
721ad07 
…-and-Krazo"

This reverts commit 5d78710, reversing
changes made to 0156e77.
Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Feb 18, 2025
@Pandrex247
Merge pull request payara#7089 from Pandrex247/FISH-10211-MVC-and-Krazo
3f74822 
FISH-10211 MVC 2.1 and Krazo 3.0
Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Feb 19, 2025
@Pandrex247
Merge pull request payara#7089 from Pandrex247/FISH-10211-MVC-and-Krazo
1a08c6a 
FISH-10211 MVC 2.1 and Krazo 3.0
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@breakponchito breakponchito breakponchito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pandrex247 @breakponchito