Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

better 'not implemented' messages #889

Merged
merged 1 commit into from
Dec 24, 2024
Merged

better 'not implemented' messages #889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion coordinator/provider/coordinator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1878,7 +1878,7 @@ func (qc *qdbCoordinator) AddDataShard(ctx context.Context, shard *datashards.Da
}

func (qc *qdbCoordinator) AddWorldShard(_ context.Context, _ *datashards.DataShard) error {
panic("implement me")
panic("qdbCoordinator.AddWorldShard not implemented")
}

func (qc *qdbCoordinator) DropShard(ctx context.Context, shardId string) error {
Expand Down
2 changes: 1 addition & 1 deletion coordinator/provider/shards.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func (s *ShardServer) AddDataShard(ctx context.Context, request *protos.AddShard
}

func (s *ShardServer) AddWorldShard(ctx context.Context, request *protos.AddWorldShardRequest) (*emptypb.Empty, error) {
panic("implement me")
panic("ShardServer.AddWorldShard not implemented")
}

// TODO : unit tests
Expand Down
4 changes: 2 additions & 2 deletions pkg/coord/adapter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ func NewAdapter(conn *grpc.ClientConn) *Adapter {
// Returns:
// - qdb.QDB: The QDB object.
func (a *Adapter) QDB() qdb.QDB {
panic("implement me?")
panic("Adapter.QDB not implemented")
}

func (a *Adapter) Cache() *cache.SchemaCache {
panic("implement me?")
panic("Adapter.Cache not implemented")
}

// TODO : unit tests
Expand Down
6 changes: 2 additions & 4 deletions router/grpc/qrouter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,7 @@ func (l *LocalQrouterServer) AddDataShard(ctx context.Context, request *protos.A
}

func (l *LocalQrouterServer) AddWorldShard(ctx context.Context, request *protos.AddWorldShardRequest) (*emptypb.Empty, error) {
//TODO implement me
panic("implement me")
panic("LocalQrouterServer.AddWorldShard not implemented")
}

func (l *LocalQrouterServer) GetShard(ctx context.Context, request *protos.ShardRequest) (*protos.ShardReply, error) {
Expand Down Expand Up @@ -183,8 +182,7 @@ func (l *LocalQrouterServer) GetRouterStatus(ctx context.Context, _ *emptypb.Emp

// TODO : implement, unit tests
func (l *LocalQrouterServer) CloseRouter(ctx context.Context, _ *emptypb.Empty) (*emptypb.Empty, error) {
//TODO implement me
panic("implement me")
panic("LocalQrouterServer.CloseRouter not implemented")
}

// TODO : unit tests
Expand Down
3 changes: 1 addition & 2 deletions router/server/multishard.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,8 +453,7 @@ func (m *MultiShardServer) Cleanup(rule config.FrontendRule) error {
}

func (m *MultiShardServer) Sync() int64 {
//TODO implement me
panic("implement me")
panic("MultiShardServer.Sync not implemented")
}

func (m *MultiShardServer) Cancel() error {
Expand Down
Loading