Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

slowQueryRetriever.parseLog panic when query cluster_slow_query #58147

Closed
owlsome2501 opened this issue Dec 11, 2024 · 4 comments · Fixed by #58258
Closed

slowQueryRetriever.parseLog panic when query cluster_slow_query #58147

owlsome2501 opened this issue Dec 11, 2024 · 4 comments · Fixed by #58258
Assignees
@yibin87
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. impact/panic severity/major sig/execution SIG execution type/bug The issue is confirmed as a bug.

Comments

@owlsome2501
Copy link

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. Run ossinsight workload with 1 tidb, 6 tikv and 2 tiflash.
  2. Wait for the problematic slow log to be output and execute select * from information schema.cluster slow query to trigger panic.

2. What did you expect to see? (Required)

no panic.

3. What did you see instead (Required)

Image
Image
Image

  1. splitByColon function introduced by pr executor: Optimize slow log parsing's splitByColon function #54630 cannot correctly parse the problematic slow log.
  2. The parseLog function encountered an "index out of range" error while accessing the values array.

4. What is your TiDB version? (Required)

nightly
@owlsome2501 owlsome2501 added the type/bug The issue is confirmed as a bug. label Dec 11, 2024
@yibin87
Copy link
Contributor

yibin87 commented Dec 13, 2024

/assign @yibin87

@yibin87
Copy link
Contributor

yibin87 commented Dec 13, 2024

Do you know in what situation tidb will produce such problematic slow log? @owlsome2501

@yibin87 yibin87 mentioned this issue Dec 13, 2024
Merged
13 tasks
@yibin87
Copy link
Contributor

yibin87 commented Dec 13, 2024

/label affects-8.5
/label affects-8.1
/label affects-7.5
/label affects-7.1

@ti-chi-bot ti-chi-bot bot added affects-8.5 This bug affects the 8.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. and removed may-affects-8.5 may-affects-8.1 may-affects-7.5 may-affects-7.1 labels Dec 13, 2024
@yibin87
Copy link
Contributor

yibin87 commented Dec 13, 2024

/label affects-6.5
/label affects-6.1
/label affects-5.4

@ti-chi-bot ti-chi-bot bot added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. and removed may-affects-6.5 may-affects-6.1 labels Dec 13, 2024
@ti-chi-bot ti-chi-bot bot removed the may-affects-5.4 This bug maybe affects 5.4.x versions. label Dec 13, 2024
ti-chi-bot bot pushed a commit that referenced this issue Dec 16, 2024
executor: Fix the parse problematic slow log panic issue due to empty…
df0c5d1 
… value string (#58258)

close #58147
This was referenced Dec 16, 2024
Merged
Merged
Merged
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Dec 16, 2024
@ti-chi-bot
executor: Fix the parse problematic slow log panic issue due to empty…
6d05536 
… value string (#58258) (#58270)

close #58147
ti-chi-bot bot pushed a commit that referenced this issue Dec 16, 2024
@ti-chi-bot
executor: Fix the parse problematic slow log panic issue due to empty…
a763ffd 
… value string (#58258) (#58273)

close #58147
ti-chi-bot bot pushed a commit that referenced this issue Dec 16, 2024
@ti-chi-bot
executor: Fix the parse problematic slow log panic issue due to empty…
0f32738 
… value string (#58258) (#58271)

close #58147
ti-chi-bot bot pushed a commit that referenced this issue Dec 16, 2024
@ti-chi-bot
executor: Fix the parse problematic slow log panic issue due to empty…
8704a0a 
… value string (#58258) (#58274)

close #58147
ti-chi-bot bot pushed a commit that referenced this issue Dec 16, 2024
@ti-chi-bot
executor: Fix the parse problematic slow log panic issue due to empty…
8ce140d 
… value string (#58258) (#58272)

close #58147
ti-chi-bot bot pushed a commit that referenced this issue Dec 16, 2024
@ti-chi-bot
executor: Fix the parse problematic slow log panic issue due to empty…
7ce96f9 
… value string (#58258) (#58275)

close #58147
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@yibin87 yibin87

Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. impact/panic severity/major sig/execution SIG execution type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: Fix the parse problematic slow log panic issue due to empty value string yibin87/tidb
3 participants
@jebter @yibin87 @owlsome2501