Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

executor: Fix the parse problematic slow log panic issue due to empty value string (#58258) #58275

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #58258

What problem does this PR solve?

Issue Number: close #58147

Problem Summary:
Handle uncommon empty value string case in slow log. Checked that queries for system tables, like stats_meta, will generate empty copr address.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that queries for slow log may fail when some item's value is empty. 

Signed-off-by: yibin <huyibin@pingcap.cn>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 16, 2024
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 16, 2024
Copy link

ti-chi-bot bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 16, 2024
Copy link

ti-chi-bot bot commented Dec 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-16 04:03:13.593310864 +0000 UTC m=+843183.682113406: ☑️ agreed by windtalker.
  • 2024-12-16 04:03:48.456449719 +0000 UTC m=+843218.545252263: ☑️ agreed by hawkingrei.

@yibin87
Copy link
Contributor

yibin87 commented Dec 16, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2024
@yibin87
Copy link
Contributor

yibin87 commented Dec 16, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@a4f58fe). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #58275   +/-   ##
================================================
  Coverage               ?   56.9079%           
================================================
  Files                  ?       1773           
  Lines                  ?     627123           
  Branches               ?          0           
================================================
  Hits                   ?     356883           
  Misses                 ?     246057           
  Partials               ?      24183           
Flag Coverage Δ
integration 36.8712% <0.0000%> (?)
unit 72.5262% <69.2307%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8711% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.2857% <0.0000%> (?)

@yibin87
Copy link
Contributor

yibin87 commented Dec 16, 2024

/test unit-test

Copy link

tiprow bot commented Dec 16, 2024

@yibin87: No presubmit jobs available for pingcap/tidb@release-8.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yibin87
Copy link
Contributor

yibin87 commented Dec 16, 2024

/test unit-test

Copy link

tiprow bot commented Dec 16, 2024

@yibin87: No presubmit jobs available for pingcap/tidb@release-8.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 7ce96f9 into pingcap:release-8.5 Dec 16, 2024
18 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants