-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
executor: Fix the parse problematic slow log panic issue due to empty value string (#58258) #58275
executor: Fix the parse problematic slow log panic issue due to empty value string (#58258) #58275
Conversation
Signed-off-by: yibin <huyibin@pingcap.cn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/hold |
/unhold |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #58275 +/- ##
================================================
Coverage ? 56.9079%
================================================
Files ? 1773
Lines ? 627123
Branches ? 0
================================================
Hits ? 356883
Misses ? 246057
Partials ? 24183
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test unit-test |
@yibin87: No presubmit jobs available for pingcap/tidb@release-8.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test unit-test |
@yibin87: No presubmit jobs available for pingcap/tidb@release-8.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #58258
What problem does this PR solve?
Issue Number: close #58147
Problem Summary:
Handle uncommon empty value string case in slow log. Checked that queries for system tables, like stats_meta, will generate empty copr address.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.