Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

flaky assert "assert failed, TS used in import should in [now-1d, now]" #58449

Closed
D3Hunter opened this issue Dec 23, 2024 · 4 comments · Fixed by #58594
Closed

flaky assert "assert failed, TS used in import should in [now-1d, now]" #58449

D3Hunter opened this issue Dec 23, 2024 · 4 comments · Fixed by #58594
Assignees
Labels
component/ddl This issue is related to DDL of TiDB. component/test good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

D3Hunter commented Dec 23, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

in real-tikv test, the clock might out of sync between tidb and pd, so this check fails

[2024/12/20 10:33:01.029 +00:00] [ERROR] [wait_group_wrapper.go:246] ["panic in error group"] [recover="assert failed, TS used in import should in [now-1d, now], but got 454738780250439970"]


454738780250439970 is 2024-12-20 18:33:01.595000

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master

@D3Hunter D3Hunter added type/bug The issue is confirmed as a bug. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. component/test severity/moderate labels Dec 23, 2024
@lance6716
Copy link
Contributor

it's better to request another TS from PD in intest functions and check the time range

@D3Hunter
Copy link
Contributor Author

change the range to [now-1d, now+1h] wound be enough, the clock is synced with very little difference in most cases, above is within 1 second

@takaebato
Copy link
Contributor

Hi! Can I take this issue?

@lance6716
Copy link
Contributor

/assign @takaebato

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
component/ddl This issue is related to DDL of TiDB. component/test good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants