lightning: adjust TS assertion range between TiDB and PD

[takaebato]

What problem does this PR solve?

Issue Number: close #58449
Problem Summary:

Timestamp assertion was flaky due to minor clock drift between TiDB and PD.

What changed and how does it work?

Expanded the range to tolerate minor differences, allowing timestamps up to 1 hour in the future and 24 hours in the past.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

I’d greatly appreciate it if you could suggest a good place to add tests, if needed!

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix flaky assert by adjusting the TS range

[sre-bot]

All committers have signed the CLA.

[ti-chi-bot]

Welcome @takaebato!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

[ti-chi-bot]

Hi @takaebato. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiprow]

Hi @takaebato. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lance6716]

/ok-to-test

[lance6716]

/cc @D3Hunter

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.9256%. Comparing base (0097df9) to head (990b576).
Report is 31 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #58594        +/-   ##
================================================
+ Coverage   73.5142%   73.9256%   +0.4114%     
================================================
  Files          1680       1710        +30     
  Lines        464725     474869     +10144     
================================================
+ Hits         341639     351050      +9411     
- Misses       102218     102274        +56     
- Partials      20868      21545       +677     

Flag	Coverage Δ
integration	45.7191% <0.0000%> (?)
unit	72.3717% <0.0000%> (+0.1159%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.6910% <ø> (ø)
parser	∅ <ø> (∅)
br	45.7612% <ø> (-0.0133%)	⬇️

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/lightning/OWNERS [D3Hunter,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-12-30 11:22:12.89553663 +0000 UTC m=+349468.251541172: ☑️ agreed by D3Hunter.
• 2024-12-30 11:28:50.965999337 +0000 UTC m=+349866.322003877: ☑️ agreed by lance6716.