Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

go.mod: update PD client to fix TSO follower proxy switch #56679

Merged

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: close #56675.

What changed and how does it work?

Update PD client to adopt the fix tikv/pd#8719.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue where the TSO follower proxy cannot be disabled.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2024
Copy link

ti-chi-bot bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2024
Copy link

ti-chi-bot bot commented Oct 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-16 07:32:03.822525989 +0000 UTC m=+429120.971435813: ☑️ agreed by hawkingrei.
  • 2024-10-16 07:32:17.680500943 +0000 UTC m=+429134.829410775: ☑️ agreed by nolouch.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato force-pushed the fix_tso_follower_proxy_disabling branch from 004b260 to 77d9228 Compare October 16, 2024 07:38
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.6088%. Comparing base (1352db6) to head (77d9228).
Report is 3 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56679         +/-   ##
=================================================
- Coverage   73.3549%   56.6088%   -16.7461%     
=================================================
  Files          1629       1753        +124     
  Lines        450098     631085     +180987     
=================================================
+ Hits         330169     357250      +27081     
- Misses        99694     249914     +150220     
- Partials      20235      23921       +3686     
Flag Coverage Δ
integration 37.2611% <ø> (?)
unit 72.8419% <ø> (+0.3558%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.4167% <ø> (+6.8439%) ⬆️

@JmPotato
Copy link
Member Author

/test check-dev

Copy link

tiprow bot commented Oct 16, 2024

@JmPotato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test fast_test_tiprow_ddlargsv1
  • /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

  • fast_test_tiprow
  • tidb_parser_test

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JmPotato
Copy link
Member Author

/test check-dev2

Copy link

tiprow bot commented Oct 16, 2024

@JmPotato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test fast_test_tiprow_ddlargsv1
  • /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

  • fast_test_tiprow
  • tidb_parser_test

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit ff317ee into pingcap:master Oct 16, 2024
23 checks passed
@JmPotato JmPotato deleted the fix_tso_follower_proxy_disabling branch October 16, 2024 14:10
@JmPotato
Copy link
Member Author

/cherry-pick release-8.4

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 16, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@JmPotato: new pull request created to branch release-8.4: #56691.

In response to this:

/cherry-pick release-8.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSO follower proxy still effective after disabling it
4 participants