Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

client/tso: fix the issue where the TSO follower proxy cannot be closed #8719

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: close #8709.

What is changed and how does it work?

Remove outdated follower connections after disabling the TSO follower proxy.

Check List

Tests

  • Unit test
  • Integration test

Release note

Fix the issue where the TSO follower proxy cannot be closed.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato added the component/client Client logic. label Oct 16, 2024
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.73%. Comparing base (48e72f1) to head (327a599).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8719      +/-   ##
==========================================
+ Coverage   71.70%   71.73%   +0.02%     
==========================================
  Files         517      517              
  Lines       67450    67456       +6     
==========================================
+ Hits        48364    48388      +24     
+ Misses      15521    15507      -14     
+ Partials     3565     3561       -4     
Flag Coverage Δ
unittests 71.73% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 16, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 16, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-16 04:12:37.856078529 +0000 UTC m=+417155.004988353: ☑️ agreed by nolouch.
  • 2024-10-16 06:45:59.249218077 +0000 UTC m=+426356.398127909: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit b70107e into tikv:master Oct 16, 2024
25 of 26 checks passed
@JmPotato JmPotato deleted the fix_tso_follower_proxy_disabling branch October 16, 2024 06:50
@JmPotato
Copy link
Member Author

/cherry-pick release-8.4

@ti-chi-bot
Copy link
Member

@JmPotato: new pull request created to branch release-8.4: #8721.

In response to this:

/cherry-pick release-8.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Oct 16, 2024
…ed (#8719) (#8721)

close #8709

Remove outdated follower connections after disabling the TSO follower proxy.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: JmPotato <ghzpotato@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved component/client Client logic. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSO follower proxy still effective after disabling it
4 participants