Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

lightning: adjust TS assertion range between TiDB and PD #58594

Merged
merged 1 commit into from
Dec 30, 2024
Merged

lightning: adjust TS assertion range between TiDB and PD #58594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/lightning/backend/local/region_job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,14 +440,14 @@ func (local *Backend) doWrite(ctx context.Context, j *regionJob) error {
intest.AssertFunc(func() bool {
timeOfTS := oracle.GetTimeFromTS(dataCommitTS)
now := time.Now()
if timeOfTS.After(now) {
if timeOfTS.Sub(now) > time.Hour {
return false
}
if now.Sub(timeOfTS) > 24*time.Hour {
return false
}
return true
}, "TS used in import should in [now-1d, now], but got %d", dataCommitTS)
}, "TS used in import should in [now-1d, now+1h], but got %d", dataCommitTS)
if dataCommitTS == 0 {
return errors.New("data commitTS is 0")
}
Expand Down