Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Transaction metric collection #1069

Closed
Xylus opened this issue Oct 13, 2015 · 5 comments
Closed

Add Transaction metric collection #1069

Xylus opened this issue Oct 13, 2015 · 5 comments
Assignees
@Xylus
Labels
enhancement
Milestone
1.5.0

Comments

@Xylus
Copy link
Contributor

Xylus commented Oct 13, 2015

Add per-agent transaction count metric collection support for all 4 types of transactions:

  1. Sampled New
  2. Unsampled New
  3. Sampled Continuation
  4. Unsampled Continuation
@Xylus Xylus self-assigned this Oct 13, 2015
@Xylus Xylus added this to the 1.5.0 milestone Oct 13, 2015
Xylus added a commit to Xylus/pinpoint that referenced this issue Oct 14, 2015
@Xylus
pinpoint-apm#1069 Add tps collection support for agent
c393925
Xylus added a commit to Xylus/pinpoint that referenced this issue Oct 14, 2015
@Xylus
pinpoint-apm#1069 Add backend support for storing and retrieving tps
be4a50d
Xylus added a commit to Xylus/pinpoint that referenced this issue Oct 15, 2015
@Xylus
pinpoint-apm#1069 Add tps collection support for agent
200ce6f
Xylus added a commit to Xylus/pinpoint that referenced this issue Oct 15, 2015
@Xylus
pinpoint-apm#1069 Add backend support for storing and retrieving tps
a40af85
@Xylus Xylus mentioned this issue Oct 15, 2015
Merged
@Xylus
Copy link
Contributor Author

Xylus commented Oct 21, 2015

Currently tps is calculated by factoring in the following situations:

  1. When a new trace is created and should be sampled.
  2. When a new trace is created and should not be sampled.
  3. When a trace is continued with sampling set false.

Need to consider 1 more situation:

  1. When a trace is continued, and sampling is set true.

@Xylus
Copy link
Contributor Author

Xylus commented Oct 23, 2015

Should continue after #1103

Xylus added a commit to Xylus/pinpoint that referenced this issue Oct 27, 2015
@Xylus
pinpoint-apm#1069 Add transaction counting/tps calculation for contin…
6803625 
…ued traces
@Xylus
Copy link
Contributor Author

Xylus commented Oct 27, 2015

Changing spec to collect the number of transaction over a certain period of time.
Tps calculation will be done when querying using this data.

@Xylus Xylus changed the title Add TPS metric collection Add Transaction metric collection Oct 27, 2015
Xylus added a commit to Xylus/pinpoint that referenced this issue Oct 28, 2015
@Xylus
pinpoint-apm#1069 Add transaction metric support
b6367f5
@Xylus Xylus mentioned this issue Oct 28, 2015
Merged
@Xylus
Copy link
Contributor Author

Xylus commented Oct 29, 2015

Reopening to remove version field.

@Xylus Xylus reopened this Oct 29, 2015
Xylus added a commit to Xylus/pinpoint that referenced this issue Oct 29, 2015
@Xylus
pinpoint-apm#1069 Remove version field from TTransaction Thrift object
7ff7cac
@Xylus Xylus mentioned this issue Oct 29, 2015
Merged
@Xylus
Copy link
Contributor Author

Xylus commented Oct 30, 2015

Reopening for UI

@Xylus Xylus reopened this Oct 30, 2015
Xylus added a commit to Xylus/pinpoint that referenced this issue Oct 30, 2015
@Xylus
pinpoint-apm#1069 Add TPS chart to Inspector View
ad01b6a
@Xylus Xylus mentioned this issue Oct 30, 2015
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Xylus Xylus

Labels
enhancement
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
1 participant
@Xylus