Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Separate id used for internal trace map from transaction id used for context propagation #1103

Closed
Xylus opened this issue Oct 23, 2015 · 1 comment
Assignees
Milestone

Comments

@Xylus
Copy link
Contributor

Xylus commented Oct 23, 2015

A single id was used for both transactionId for context propagation, and trace map cache (as key).
This approach however does not work well for cases when a transaction is continued. For a continued transaction, using the transactionId as the map key may conflict with transactionId issued for new transactions.

Separating id used for trace map key (at least for continued transactions) would fix the problem.
This should be done using the least amount of atomic counters that covers id generation for 4 cases:

  1. New Sampled Trace
  2. New Unsampled Trace
  3. Continued Sampled Trace
  4. Continued Unsampled Trace
@Xylus Xylus self-assigned this Oct 23, 2015
@Xylus Xylus added this to the 1.5.0 milestone Oct 23, 2015
Xylus added a commit to Xylus/pinpoint that referenced this issue Oct 27, 2015
@Xylus Xylus closed this as completed Oct 28, 2015
@Xylus
Copy link
Contributor Author

Xylus commented Oct 29, 2015

Generate id differently (currently divides the Long space into 4)
Better to leave some space for future use.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant