Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Same Application with different server type should be selectable separately. #214

Closed
Xylus opened this issue Mar 6, 2015 · 2 comments
Closed
Assignees
Milestone

Comments

@Xylus
Copy link
Contributor

Xylus commented Mar 6, 2015

The application selector in the Web UI displays only one selectable choice for application name even if they may have different service types.

Since the server map is rendered and grouped by application name and service type, application name selector should work the same way.

Additionally, this should solve an issue where if an agent changed its agent ID + service type while maintaining the same application name, the application selector would not reflect this change.

@Xylus Xylus self-assigned this Mar 6, 2015
Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 6, 2015
The application list is now generates additional applications for each
service type registered under the same application name.
@Xylus
Copy link
Contributor Author

Xylus commented Mar 9, 2015

The server map is displayed correctly when selecting between the same applications with different agent types.

The scatter chart data (both filtered and non-filtered) however does not include the agent type when querying, thus displaying all of the traces regardless of their agent type.

Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 9, 2015
The application list is now generates additional applications for each
service type registered under the same application name.
@Xylus
Copy link
Contributor Author

Xylus commented Mar 9, 2015

Indexed trace data do not contain service type, so there is currently no way to filter the scatter chart by agent type.

We could make it work but it would require too much change and even break compatibility with the data already stored.

Situations such as above should not occur in normal operation as different applications should not share the same application name and agent id.

Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 9, 2015
The application list is now generates additional applications for each
service type registered under the same application name.
Xylus added a commit that referenced this issue Mar 9, 2015
change how the application list is generated - #214
@Xylus Xylus closed this as completed Mar 10, 2015
@emeroad emeroad added this to the 1.1.0 milestone Mar 17, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants