Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

User node pointing to a node with same application name but different service type throws an exception #254

Closed
Xylus opened this issue Mar 24, 2015 · 0 comments · Fixed by #260
Assignees
Milestone

Comments

@Xylus
Copy link
Contributor

Xylus commented Mar 24, 2015

In relation to issue #214, applications with the same application name can now be selected separately as long as their service types differ.
However, user nodes are generated on the server map taking only the destination's application name into account.

For example, if there are 2 nodes with the same application name but different service type (ie TOMCAT, SPRING-BOOT both named myApp) with 2 USER nodes each pointing to myApp[TOMCAT], and myApp[SPRING-BOOT], the Web UI throws an error when drawing the server map.
This is because the USER node is generated by extracting the application name of the destination node, which in this case would result in only a single USER node being generated.
current

2 possible solutions exist.

  1. Draw only a single USER node that points to both myApp[TOMCAT] and myApp[SPRING-BOOT].
    solution1
  2. Draw 2 separate USER nodes each pointing to myApp[TOMCAT] and myApp[SPRING-BOOT].
    solution2

The second solution seems like the better option - but this requires the destination node's service type to already be stored in hbase.

@Xylus Xylus self-assigned this Mar 24, 2015
@Xylus Xylus added this to the 1.1.0 milestone Mar 24, 2015
Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 26, 2015
…e same app name

An exception is thrown when drawing the server map in situations where
users call multiple nodes with the same application name (but different
service types). This was caused because it was not possible to have a
single user node pointing to more than 1 destination node.

The user nodes are uniquely identified by their destination node's
application name only and this resulted in only a single user node being
created when there were multiple nodes with the same application name.

This commit fixes the issue by taking the destination node's service
type into account when creating user nodes.
Xylus added a commit that referenced this issue Mar 26, 2015
#254 fix exception when user node points to nodes with the same app name
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant