Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support version like patch form #9918

Closed
1 task done
koo-taejin opened this issue May 2, 2023 · 0 comments · Fixed by #9917
Closed
1 task done

Support version like patch form #9918

koo-taejin opened this issue May 2, 2023 · 0 comments · Fixed by #9917
Assignees
@koo-taejin
Labels
bug module:agent
Milestone
3.0.0

Comments

@koo-taejin
Copy link
Member

Prerequisites

Please check the FAQ, and search existing issues for similar questions before creating a new issue.YOU MAY DELETE THIS PREREQUISITES SECTION.

  • I have checked the FAQ, and issues and found no answer.

What version of pinpoint are you using?

tags/v2.5.1-p1

Describe the bug

I have checked that an error occurs when running with agent of latest released 2.5.1-p1 version.
(If you build and use the 2.5.1-p1 tag, then you can get following error .)

java.lang.IllegalStateException: pinpoint-bootstrap-x.x.x(-SNAPSHOT)(-RCx).jar not found.
	at com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolver.resolve(AgentDirBaseClassPathResolver.java:73)
	at com.navercorp.pinpoint.bootstrap.PinpointBootStrap.resolveAgentDir(PinpointBootStrap.java:132)
	at com.navercorp.pinpoint.bootstrap.PinpointBootStrap.start(PinpointBootStrap.java:100)

It seems that the version like patch from (-p1) is not supported,

What did you do to trigger the bug?

Expected behavior

Screenshots

Logs

Additional context

related PR : #9917
@koo-taejin koo-taejin self-assigned this May 2, 2023
@koo-taejin koo-taejin added this to the 2.6.0 milestone May 2, 2023
@emeroad emeroad linked a pull request May 2, 2023 that will close this issue
[#9918] Support version like patch form #9917
Merged
emeroad pushed a commit that referenced this issue May 3, 2023
@koo-taejin @emeroad
[#9918] Support version like patch form
721abe3 
I have checked that an error occurs when running with agent of latest released 2.5.1-p1 version.

```
java.lang.IllegalStateException: pinpoint-bootstrap-x.x.x(-SNAPSHOT)(-RCx).jar not found.
	at com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolver.resolve(AgentDirBaseClassPathResolver.java:73)
	at com.navercorp.pinpoint.bootstrap.PinpointBootStrap.resolveAgentDir(PinpointBootStrap.java:132)
	at com.navercorp.pinpoint.bootstrap.PinpointBootStrap.start(PinpointBootStrap.java:100)
```

It seems that the version like patch from (-p1) is not supported, I have fixed it.
@intr3p1d intr3p1d mentioned this issue Nov 7, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@koo-taejin koo-taejin

Labels
bug module:agent
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

[#9918] Support version like patch form koo-taejin/pinpoint
1 participant
@koo-taejin