Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[#9918] Support version like patch form #9917

Merged

Conversation

koo-taejin
Copy link
Member

@koo-taejin koo-taejin commented May 2, 2023

Hi.

I have checked that an error occurs when running with agent of latest released 2.5.1-p1 version.
(If you build and use the 2.5.1-p1 tag, then you can get following error .)

java.lang.IllegalStateException: pinpoint-bootstrap-x.x.x(-SNAPSHOT)(-RCx).jar not found.
	at com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolver.resolve(AgentDirBaseClassPathResolver.java:73)
	at com.navercorp.pinpoint.bootstrap.PinpointBootStrap.resolveAgentDir(PinpointBootStrap.java:132)
	at com.navercorp.pinpoint.bootstrap.PinpointBootStrap.start(PinpointBootStrap.java:100)

It seems that the version like patch from (-p1) is not supported, I have fixed it.

You can close the PR at any time if your intention is to not support building and using it.

Thanks :)

I have checked that an error occurs when running with agent of latest released 2.5.1-p1 version.

```
java.lang.IllegalStateException: pinpoint-bootstrap-x.x.x(-SNAPSHOT)(-RCx).jar not found.
	at com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolver.resolve(AgentDirBaseClassPathResolver.java:73)
	at com.navercorp.pinpoint.bootstrap.PinpointBootStrap.resolveAgentDir(PinpointBootStrap.java:132)
	at com.navercorp.pinpoint.bootstrap.PinpointBootStrap.start(PinpointBootStrap.java:100)
```

It seems that the version like patch from (-p1) is not supported, I have fixed it.
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #9917 (0f3b104) into master (6f2d1cb) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9917      +/-   ##
============================================
- Coverage     38.87%   38.86%   -0.01%     
- Complexity    11888    11909      +21     
============================================
  Files          3486     3538      +52     
  Lines         93747    93973     +226     
  Branches      10524    10493      -31     
============================================
+ Hits          36445    36527      +82     
- Misses        54141    54274     +133     
- Partials       3161     3172      +11     
Impacted Files Coverage Δ
...tstrap/agentdir/AgentDirBaseClassPathResolver.java 55.00% <ø> (+1.15%) ⬆️
...rp/pinpoint/bootstrap/agentdir/JarDescription.java 77.77% <ø> (ø)

... and 546 files with indirect coverage changes

@emeroad emeroad added this to the 2.6.0 milestone May 2, 2023
@emeroad
Copy link
Member

emeroad commented May 2, 2023

Thank you for your contribution.
If you don't mind, Could you create an issue?

@koo-taejin
Copy link
Member Author

Thanks.
I am going to make issue :)

@koo-taejin koo-taejin mentioned this pull request May 2, 2023
1 task
@koo-taejin koo-taejin changed the title [#Noissue] Support version like patch form [#9918] Support version like patch form May 2, 2023
@emeroad emeroad linked an issue May 2, 2023 that may be closed by this pull request
1 task
@emeroad emeroad merged commit 7d1310d into pinpoint-apm:master May 2, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support version like patch form
2 participants