Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Fix typo in EnhancedTab disabled_className property #934

Merged
merged 3 commits into from
Mar 15, 2021
Merged

Fix typo in EnhancedTab disabled_className property #934

merged 3 commits into from
Mar 15, 2021

Conversation

ivanna-ostrovets
Copy link
Contributor

I was trying to add custom className for the disabled tab through disabled_className and faced an issue that the component received undefined instead of the provided string. Turned out that the property name was misspelled. So I fixed this by renaming property from disabled_classname to disabled_className.

@alexcjohnson
Copy link
Collaborator

Great catch, thanks @ivanna-ostrovets! Would you mind doing two more things to finish this up? (1) add a changelog entry under UNRELEASED -> Fixed, (2) include disabled_className in a test and verify that it shows up in the DOM - Maybe just add a disabled tab here:

dcc.Tab(label="Tab Two", value="tab-2-example", id="tab-2"),

and then down below:

tab_two = dash_dcc.wait_for_element("#tab-2")

add another line like

dash_dcc.wait_for_element("#tab-3.my-disabled-class")

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you! 💃

@alexcjohnson alexcjohnson merged commit 1b354ae into plotly:dev Mar 15, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants