Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Fix typo in EnhancedTab disabled_className property #934

Merged
merged 3 commits into from
Mar 15, 2021
Merged

Fix typo in EnhancedTab disabled_className property #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b95c093
Fix typo in EnhancedTab disabled_className property
ivanna-ostrovets Mar 12, 2021
2f449f1
Add changelog entry for EnhancedTab fix
ivanna-ostrovets Mar 14, 2021
41e44e1
Add test for checking disabled_className property shows in DOM
ivanna-ostrovets Mar 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).

### Fixed
- [#930](https://github.com/plotly/dash-core-components/pull/930) Fixed a bug [#867](https://github.com/plotly/dash-core-components/issues/867) with `DatePickerRange` that would sometimes shift the allowed dates by one day.
- [#934](https://github.com/plotly/dash-core-components/pull/934) Fixed a bug in `EnhancedTab` component that ignored `disabled_className` property

## [1.15.0] - 2021-01-19
### Fixed
Expand Down
2 changes: 1 addition & 1 deletion src/components/Tabs.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ export default class Tabs extends Component {
value={childProps.value}
disabled={childProps.disabled}
disabled_style={childProps.disabled_style}
disabled_classname={childProps.disabled_className}
disabled_className={childProps.disabled_className}
mobile_breakpoint={this.props.mobile_breakpoint}
vertical={this.props.vertical}
amountOfTabs={amountOfTabs}
Expand Down
10 changes: 10 additions & 0 deletions tests/integration/tab/test_tabs_with_graphs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ def test_graph_does_not_resize_in_tabs(dash_dcc, is_eager):
children=[
dcc.Tab(label="Tab One", value="tab-1-example", id="tab-1"),
dcc.Tab(label="Tab Two", value="tab-2-example", id="tab-2"),
dcc.Tab(
label="Tab Three",
value="tab-3-example",
id="tab-3",
disabled=True,
disabled_className="disabled-tab",
),
],
),
html.Div(id="tabs-content-example"),
Expand Down Expand Up @@ -64,6 +71,9 @@ def render_content(tab):
tab_one = dash_dcc.wait_for_element("#tab-1")
tab_two = dash_dcc.wait_for_element("#tab-2")

# wait for disabled tab with custom className
dash_dcc.wait_for_element("#tab-3.disabled-tab")

WebDriverWait(dash_dcc.driver, 10).until(
EC.element_to_be_clickable((By.ID, "tab-2"))
)
Expand Down