persist callback graph layout when callbacks fire #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
commented
Sep 15, 2020
| dash_duo.find_element("#add").click() | ||
| dash_duo.find_element(".dash-debug-menu__button--callbacks").click() |
There was a problem hiding this comment.
Worked fine locally but failed on CI before this commit, because the "Add" button was hidden by the callback graph. The bug still applies if the callbacks are fired while the graph is hidden, so that's what the test now does... but this brings up that it would be nice at some point to be able to shrink and/or move the callback graph so you can still interact with whichever parts of the app you want to while it's open.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1401
Fixes #1402
The way I stored the callback graph layout is hacky: I just mutated the value in the redux store directly to insert it. I did this because I didn't want it to trigger a rerender of the callback graph (a potentially infinite loop), since I'm just recording changes that have already been drawn by cytoscape, so that they'll be available for the next time the graph is rendered. But I neglected to check that this info stuck around when new profile information is added - now it does. If there's a better pattern for this kind of use case I'd be happy to learn about it, but this works. I included a test specifically for #1402 but #1401 is also solved, it's the same issue.
Contributor Checklist
optionals
CHANGELOG.md