Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

persist callback graph layout when callbacks fire #1408

Merged
merged 5 commits into from
Sep 15, 2020
Merged

persist callback graph layout when callbacks fire #1408

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f523cb7
persist callback graph layout when callbacks fire
alexcjohnson Sep 15, 2020
3a6222c
changelog for callback graph layout fix
alexcjohnson Sep 15, 2020
8b3abd2
fix new callback graph layout test for small CI screen
alexcjohnson Sep 15, 2020
906884b
comments on the graphLayout hack
alexcjohnson Sep 15, 2020
fe60ea5
noise
alexcjohnson Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tests/integration/devtools/test_devtools_ui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,12 @@ def test_dvui003_callback_graph(dash_duo):

# hide and redraw the callback graph so we get the new position
dash_duo.find_element(".dash-debug-menu__button--callbacks").click()
dash_duo.find_element(".dash-debug-menu__button--callbacks").click()
sleep(2)

# fire callbacks so the callback graph redraws again
# fire callbacks so the profile state is regenerated
dash_duo.find_element("#add").click()
dash_duo.find_element(".dash-debug-menu__button--callbacks").click()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked fine locally but failed on CI before this commit, because the "Add" button was hidden by the callback graph. The bug still applies if the callbacks are fired while the graph is hidden, so that's what the test now does... but this brings up that it would be nice at some point to be able to shrink and/or move the callback graph so you can still interact with whichever parts of the app you want to while it's open.

dash_duo.wait_for_text_to_equal("#totals", "0 of 1 items completed - 0%")
sleep(1)
sleep(2)
# the manually moved node is still in its new position
assert pos == dash_duo.driver.execute_script(
"""
Expand Down