Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

julia non-core components: require Dash 0.1.3 #1434

Merged
merged 3 commits into from
Oct 26, 2020
Merged

Conversation

alexcjohnson
Copy link
Collaborator

@alexcjohnson alexcjohnson commented Oct 13, 2020

Closes #1432 (to require plotly/Dash.jl#68)

  • I have added entry in the CHANGELOG.md

@rpkyle can you test this with facultyai/dash-bootstrap-components#464?

@alexcjohnson
Copy link
Collaborator Author

Getting test failures assert dash_duo.get_logs() == [] is failing with this in the console:

'message': 'http://localhost:8050/_dash-component-suites/dash_renderer/prop-types@15.v1_8_2m1602275212.7.2.js '
           '193:14 "Warning: Invalid argument supplied to oneOfType. '
           'Expected an array of check functions, but received undefined at '
           'index 0."',

Investigating... it looks unrelated to this PR, as #1429 has the same errors. Chrome version change? New sub-dependency version?

@rpkyle
Copy link
Contributor

rpkyle commented Oct 14, 2020

@alexcjohnson Looks good over here, the Project.toml seems to have the right information, and I was able to load DashBootstrapComponents independently without errors:

name = "DashBootstrapComponents"
uuid = "1b08a953-4be3-4667-9a23-fa6d05876a1e"
authors = ["Faculty <opensource@faculty.ai>"]
version = "0.10.8-dev"

[deps]
Dash = "1b08a953-4be3-4667-9a23-3db579824955"

[compat]
julia = "1.2"
Dash = "0.1.3"

@alexcjohnson
Copy link
Collaborator Author

@Marc-Andre-Rivet now that tests are passing again (thanks!) ok to merge this?

@rpkyle rpkyle self-requested a review October 26, 2020 18:27
Copy link
Contributor

@rpkyle rpkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 LGTM

@alexcjohnson alexcjohnson merged commit 1122fd4 into dev Oct 26, 2020
@alexcjohnson alexcjohnson deleted the julia-noncore-fix branch October 26, 2020 18:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing Dash.jl component libraries prior to Dash throws a "UndefVarError: DashBase not defined" error
2 participants