Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

julia non-core components: require Dash 0.1.3 #1434

Merged
merged 3 commits into from
Oct 26, 2020
+14 −2
Merged

julia non-core components: require Dash 0.1.3 #1434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef59d48
julia non-core components: require Dash 0.1.3
alexcjohnson Oct 13, 2020
e9e469b
julia non-core component gen fix changelog
alexcjohnson Oct 13, 2020
40bef9c
Merge branch 'dev' into julia-noncore-fix
alexcjohnson Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
All notable changes to `dash` will be documented in this file.
This project adheres to [Semantic Versioning](https://semver.org/).

## [UNRELEASED]
### Fixed
- [#1434](https://github.com/plotly/dash/pull/1434) Fix [#1432](https://github.com/plotly/dash/issues/1432) for Julia to import non-core component packages without possible errors.

## [1.16.3] - 2020-10-07
### Fixed
- [#1426](https://github.com/plotly/dash/pull/1426) Fix a regression caused by `flask-compress==1.6.0` causing performance degradation on server requests
Expand Down
12 changes: 10 additions & 2 deletions dash/development/_jl_components_generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,14 @@
[compat]
julia = "1.2"
{base_package} = "0.1"
{base_package} = "{base_version}"
"""

jl_base_version = {
"Dash": "0.1.3",
"DashBase": "0.1",
}

jl_component_include_string = 'include("{name}.jl")'

jl_resource_tuple_string = """DashBase.Resource(
Expand Down Expand Up @@ -417,12 +422,15 @@ def generate_toml_file(project_shortname, pkg_data):
'authors = ["{}"]\n'.format(package_author) if package_author else ""
)

base_package = base_package_name(project_shortname)

toml_string = jl_projecttoml_string.format(
package_name=package_name,
package_uuid=package_uuid,
version=project_ver,
authors=authors_string,
base_package=base_package_name(project_shortname),
base_package=base_package,
base_version=jl_base_version[base_package],
dash_uuid=base_package_uid(project_shortname),
)
file_path = "Project.toml"
Expand Down