Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CMake support #138

Closed
2 tasks done
pmed opened this issue Jun 23, 2020 · 5 comments
Closed
2 tasks done

CMake support #138

pmed opened this issue Jun 23, 2020 · 5 comments
Milestone
version 1.8

Comments

@pmed
Copy link
Owner

pmed commented Jun 23, 2020 •
edited
Loading

Add CMakeLists.txt to build the library with different configuration options, those are currently available in config.h.

Make it ready to publish in a C++ package manager (e.g. vcpkg, Conan)

  • CMake project with library, tests, samples
  • Node.js examples t's not worth it right now
  • Add build options and instructions to README.md
@pmed pmed mentioned this issue Jun 23, 2020
Closed
@paulocoutinhox
Copy link

Hi,

It was done?

Thanks

YarikTH added a commit to YarikTH/v8pp that referenced this issue Jul 20, 2021
@YarikTH
pmed#138 Initial CMake support. Intended to use as cmake subdirectory
006f9d9
@YarikTH
Copy link
Contributor

YarikTH commented Aug 6, 2021

@pmed Do you have any interest in CMake support? I can polish my implementation and make a PR.

@paulocoutinhox
Copy link

To me will be nice.

But im not the owner :p

YarikTH added a commit to YarikTH/v8pp that referenced this issue Aug 7, 2021
@YarikTH
pmed#138 Add initial CMake support
75e05a5
YarikTH added a commit to YarikTH/v8pp that referenced this issue Aug 7, 2021
@YarikTH
pmed#138 Add initial CMake support
9f6d666
YarikTH added a commit to YarikTH/v8pp that referenced this issue Aug 7, 2021
@YarikTH
pmed#138 Add initial CMake support
2f7d5c9
YarikTH added a commit to YarikTH/v8pp that referenced this issue Aug 7, 2021
@YarikTH
pmed#138 Add initial CMake support
feb4fb9
YarikTH added a commit to YarikTH/v8pp that referenced this issue Aug 7, 2021
@YarikTH
pmed#138 Add initial CMake support
d9784e6
YarikTH added a commit to YarikTH/v8pp that referenced this issue Aug 7, 2021
@YarikTH
pmed#138 Add initial CMake support
773723a
YarikTH added a commit to YarikTH/v8pp that referenced this issue Aug 8, 2021
@YarikTH
pmed#138 Add initial CMake support
061a1f3
YarikTH added a commit to YarikTH/v8pp that referenced this issue Aug 8, 2021
@YarikTH
pmed#138 Add initial CMake support
10bb812
@pmed pmed added this to the version 1.8 milestone Aug 12, 2021
@pmed pmed mentioned this issue Aug 12, 2021
Closed
3 tasks
@Segfaultd
Copy link

Thank you for implementing this, really needed 🙏🏻

YarikTH added a commit to YarikTH/v8pp that referenced this issue Sep 5, 2021
@YarikTH
pmed#138 Add initial CMake support
44ffb9f
pmed added a commit that referenced this issue Sep 12, 2021
@pmed
initial cmake support
38c7485 
generate v8pp/config.hpp with CMake variables

see #138
pmed pushed a commit that referenced this issue Sep 12, 2021
@YarikTH
modularize CMakeLists.txt files, add FindV8.cmake
bd50d6c 
See #138 Add initial CMake support
pmed pushed a commit that referenced this issue Sep 12, 2021
move CMake related files to cmake dir
a8df6fa 
See #138
@pmed pmed mentioned this issue Sep 12, 2021
Merged
pmed added a commit that referenced this issue Sep 12, 2021
@pmed
move CMake related files to cmake dir
57a7114 
See #138
pmed added a commit that referenced this issue Sep 26, 2021
@pmed
cmake build on Windows
5877afb 
at least with Ninja. Try to use V8 nuget packages in FindV8.cmake

See #138, #171
pmed added a commit that referenced this issue Sep 26, 2021
@pmed
add build instructions to README
6f523a4 
see #138
@pmed
Copy link
Owner Author

pmed commented Sep 26, 2021

Done in #173

@pmed pmed closed this as completed Sep 26, 2021
pmed added a commit that referenced this issue Sep 26, 2021
@pmed
initial cmake support
58149e5 
generate v8pp/config.hpp with CMake variables

see #138

(cherry picked from commit 38c7485)
pmed pushed a commit that referenced this issue Sep 26, 2021
@YarikTH @pmed
modularize CMakeLists.txt files, add FindV8.cmake
7fc4991 
See #138 Add initial CMake support

(cherry picked from commit bd50d6c)
pmed added a commit that referenced this issue Sep 26, 2021
@pmed
move CMake related files to cmake dir
86d80f3 
See #138

(cherry picked from commit 57a7114)
pmed added a commit that referenced this issue Sep 26, 2021
@pmed
cmake build on Windows
049615f 
at least with Ninja. Try to use V8 nuget packages in FindV8.cmake

See #138, #171

(cherry picked from commit 5877afb)
pmed added a commit that referenced this issue Sep 26, 2021
@pmed
add build instructions to README
750304c 
see #138

(cherry picked from commit 6f523a4)
pmed added a commit that referenced this issue Oct 3, 2021
@pmed
remove generated config.hpp from the source tree
d69048d 
since it's been generated from v8pp/config.hpp.in by CMake.
Fix default value for `V8PP_PLUGIN_SUFFIX` option.
Fix v8pp install step in the CMake files.

See #138
pmed added a commit that referenced this issue Oct 3, 2021
@pmed
remove generated config.hpp from the source tree
e36ccba 
since it's been generated from v8pp/config.hpp.in by CMake.
Fix default value for `V8PP_PLUGIN_SUFFIX` option.
Fix v8pp install step in the CMake files.

See #138

(cherry picked from commit d69048d)
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
version 1.8
Development

No branches or pull requests
4 participants
@paulocoutinhox @pmed @Segfaultd @YarikTH